From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11777 invoked by alias); 30 Dec 2014 23:22:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11763 invoked by uid 89); 30 Dec 2014 23:22:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: elasmtp-kukur.atl.sa.earthlink.net Received: from elasmtp-kukur.atl.sa.earthlink.net (HELO elasmtp-kukur.atl.sa.earthlink.net) (209.86.89.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Dec 2014 23:22:27 +0000 Received: from [68.104.56.205] (helo=macbook2.local) by elasmtp-kukur.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1Y667N-0005OZ-Ir for gdb-patches@sourceware.org; Tue, 30 Dec 2014 18:22:25 -0500 Message-ID: <54A333AE.1030904@earthlink.net> Date: Tue, 30 Dec 2014 23:22:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: RFC: remove "info dll" alias to "info sharedlibraries"? References: <20141230075437.GG2123@adacore.com> In-Reply-To: <20141230075437.GG2123@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940a6c483c08749fef1054d2cbdc29b2b3c350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00688.txt.bz2 On 12/29/14 11:54 PM, Joel Brobecker wrote: > I noticed that windows-nat's _init function makes use of a deprecated > feature: > > deprecated_init_ui_hook = set_windows_aliases; > > ... where set_windows_aliases just creates an "info dll" alias to > "info sharedlibraries". I think we can rid of the > deprecated_init_ui_hook by simply call add_info_alias in the _init > function, but I'm actually wondering why we wouldn't be able to > just deprecate and then delete the command altogether. We've already > trained the users to use the "sharedlibrary" command, so "info > sharedlibrary" should be easy, and it'll be more consistent with > other targets. What's the basis for believing that "we've already trained the users"? With a little poking around the net, I did notice a couple examples where people were reporting "info dll" results. But in practice I suspect that most GDB-using Windows developers are working on multiple platforms, and they're likely to prefer commands that work everywhere. On the other hand, "info dll" has been documented for a long time, and is only one line of extra code - seems like more work to remove than to leave it alone. I do think we can dump the hook and just use add_info_alias. I don't remember exactly why the hook seemed necessary in the first place, but the timing suggests I added it for gdbtk or MPW (or both. :-) ). Stan stan@codesourcery.com