From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18075 invoked by alias); 29 Dec 2014 11:12:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18065 invoked by uid 89); 29 Dec 2014 11:12:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 29 Dec 2014 11:12:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBTBCdRK024810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Dec 2014 06:12:40 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBTBCTus013659; Mon, 29 Dec 2014 06:12:34 -0500 Message-ID: <54A1371C.7000309@redhat.com> Date: Mon, 29 Dec 2014 11:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sergio Durigan Junior , Andreas Schwab CC: GDB Patches Subject: Re: [PATCH] Sanitize input_interrupt output References: <1419657863-13470-1-git-send-email-sergiodj@redhat.com> <87lhlslbqg.fsf@redhat.com> In-Reply-To: <87lhlslbqg.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00661.txt.bz2 On 12/28/2014 03:00 AM, Sergio Durigan Junior wrote: > On Saturday, December 27 2014, Andreas Schwab wrote: > >> Sergio Durigan Junior writes: >> >>> + { >>> + fprintf (stderr, "input_interrupt, count = %d c = %d ", cc, c); >>> + if (isprint (c)) >>> + fprintf (stderr, "('%c')\n", c); >>> + else >>> + fprintf (stderr, "('\\x%02x)\n", c & 0xFF); >> ^ >> >> Missing second quote character. > > Ops, thanks. Corrected version below. OK, but please write "0xff" in lowercase. Thanks! Pedro Alves