From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11957 invoked by alias); 18 Dec 2014 18:26:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11935 invoked by uid 89); 18 Dec 2014 18:26:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 18 Dec 2014 18:26:08 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id AB.18.03307.07BC2945; Thu, 18 Dec 2014 13:41:20 +0100 (CET) Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.84) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 18 Dec 2014 13:26:06 -0500 Message-ID: <54931C3C.6030101@ericsson.com> Date: Thu, 18 Dec 2014 18:26:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches Subject: Re: [PATCH] A few comment cleanups References: <1418842893-21536-1-git-send-email-simon.marchi@ericsson.com> <5491F976.50804@ericsson.com> In-Reply-To: Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms050802080308060309020002" X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00544.txt.bz2 --------------ms050802080308060309020002 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 7462 On 2014-12-17 05:30 PM, Doug Evans wrote: > On Wed, Dec 17, 2014 at 1:45 PM, Simon Marchi = wrote: >> On 2014-12-17 02:37 PM, Doug Evans wrote: >>> On Wed, Dec 17, 2014 at 11:01 AM, Simon Marchi >>> wrote: >>>> I stumbled upon a few comments that I think are outdated. >>>> >>>> Comment for elfread.c (elf_symfile_init): As far as history goes in gi= t, >>>> I don't see anything related to that. >>>> >>>> Comment for elfread.c (elf_symfile_read): References a parameter that = was >>>> removed in 1999. >>>> >>>> Comment for struct sym_fns/sym_offsets: References a parameter that was >>>> changed in 1999. >>>> >>>> gdb/ChangeLog: >>>> >>>> * elfread.c (elf_symfile_init): Remove stale comment. >>>> (elf_symfile_read): Same. >>>> * symfile.h (struct sym_fns): Same. >>> >>> Hi. >>> Ok with one nit, below. >>> >>>> --- >>>> gdb/elfread.c | 13 +------------ >>>> gdb/symfile.h | 6 +----- >>>> 2 files changed, 2 insertions(+), 17 deletions(-) >>>> >>>> diff --git a/gdb/elfread.c b/gdb/elfread.c >>>> index b4ec067..93e5045 100644 >>>> --- a/gdb/elfread.c >>>> +++ b/gdb/elfread.c >>>> @@ -1236,10 +1236,6 @@ elf_read_minimal_symbols (struct objfile *objfi= le, int symfile_flags, >>>> We have been initialized by a call to elf_symfile_init, which >>>> currently does nothing. >>>> >>>> - SECTION_OFFSETS is a set of offsets to apply to relocate the symbo= ls >>>> - in each section. We simplify it down to a single offset for all >>>> - symbols. FIXME. >>>> - >>>> This function only does the minimum work necessary for letting the >>>> user "name" things symbolically; it does not read the entire symta= b. >>>> Instead, it reads the external and static symbols and puts them in= partial >>>> @@ -1418,14 +1414,7 @@ elf_symfile_finish (struct objfile *objfile) >>>> dwarf2_free_objfile (objfile); >>>> } >>>> >>>> -/* ELF specific initialization routine for reading symbols. >>>> - >>>> - It is passed a pointer to a struct sym_fns which contains, among o= ther >>>> - things, the BFD for the file whose symbols are being read, and a s= lot for >>>> - a pointer to "private data" which we can fill with goodies. >>>> - >>>> - For now at least, we have nothing in particular to do, so this fun= ction is >>>> - just a stub. */ >>>> +/* ELF specific initialization routine for reading symbols. */ >>>> >>>> static void >>>> elf_symfile_init (struct objfile *objfile) >>>> diff --git a/gdb/symfile.h b/gdb/symfile.h >>>> index 1e8c230..b2cb089 100644 >>>> --- a/gdb/symfile.h >>>> +++ b/gdb/symfile.h >>>> @@ -354,11 +354,7 @@ struct sym_fns >>>> void (*sym_finish) (struct objfile *); >>>> >>>> /* This function produces a file-dependent section_offsets >>>> - structure, allocated in the objfile's storage, and based on the >>>> - parameter. The parameter is currently a CORE_ADDR (FIXME!) for >>>> - backward compatibility with the higher levels of GDB. It should >>>> - probably be changed to a string, where NULL means the default, >>>> - and others are parsed in a file dependent way. */ >>>> + structure, allocated in the objfile's storage. */ >>>> >>>> void (*sym_offsets) (struct objfile *, const struct section_addr_in= fo *); >>> >>> Can I ask you to document what the struct section_addr_info * argument = is for? >>> >> >> Hmm I am not sure my knowledge allows me to produce a useful comment. Do= n't hesitate to >> correct/enhance. Here is my first shot, after a bit of code reading: >> >> /* This function produces a file-dependent section_offsets >> structure, allocated in the objfile's storage. >> >> The section_addr_info structure contains the offset of loadable and >> allocated sections, relative to the absolute offsets found in the B= FD. */ >> >> void (*sym_offsets) (struct objfile *, const struct section_addr_info = *); >=20 > "works for me" >=20 > Thanks! Pushed with that change, thanks! =46rom db7a9bcd53534a32abf4d75a93838c6bdbf876fa Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 18 Dec 2014 11:39:44 -0500 Subject: [PATCH] A few comment cleanups I stumbled upon a few comments that I think are outdated. Comment for elfread.c (elf_symfile_init): As far as history goes in git, I don't see anything related to that. Comment for elfread.c (elf_symfile_read): References a parameter that was removed in 1999. Comment for struct sym_fns/sym_offsets: References a parameter that was changed in 1999. gdb/ChangeLog: * elfread.c (elf_symfile_init): Remove stale comment. (elf_symfile_read): Same. * symfile.h (struct sym_fns): Same. --- gdb/ChangeLog | 6 ++++++ gdb/elfread.c | 13 +------------ gdb/symfile.h | 10 +++++----- 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 348a48f..adb24d4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-12-18 Simon Marchi + + * elfread.c (elf_symfile_init): Remove stale comment. + (elf_symfile_read): Same. + * symfile.h (struct sym_fns): Same. + 2014-12-18 Nigel Stephens Maciej W. Rozycki diff --git a/gdb/elfread.c b/gdb/elfread.c index b4ec067..93e5045 100644 --- a/gdb/elfread.c +++ b/gdb/elfread.c @@ -1236,10 +1236,6 @@ elf_read_minimal_symbols (struct objfile *objfile, i= nt symfile_flags, We have been initialized by a call to elf_symfile_init, which currently does nothing. - SECTION_OFFSETS is a set of offsets to apply to relocate the symbols - in each section. We simplify it down to a single offset for all - symbols. FIXME. - This function only does the minimum work necessary for letting the user "name" things symbolically; it does not read the entire symtab. Instead, it reads the external and static symbols and puts them in part= ial @@ -1418,14 +1414,7 @@ elf_symfile_finish (struct objfile *objfile) dwarf2_free_objfile (objfile); } -/* ELF specific initialization routine for reading symbols. - - It is passed a pointer to a struct sym_fns which contains, among other - things, the BFD for the file whose symbols are being read, and a slot f= or - a pointer to "private data" which we can fill with goodies. - - For now at least, we have nothing in particular to do, so this function= is - just a stub. */ +/* ELF specific initialization routine for reading symbols. */ static void elf_symfile_init (struct objfile *objfile) diff --git a/gdb/symfile.h b/gdb/symfile.h index 1e8c230..081bc4e 100644 --- a/gdb/symfile.h +++ b/gdb/symfile.h @@ -353,12 +353,12 @@ struct sym_fns void (*sym_finish) (struct objfile *); + /* This function produces a file-dependent section_offsets - structure, allocated in the objfile's storage, and based on the - parameter. The parameter is currently a CORE_ADDR (FIXME!) for - backward compatibility with the higher levels of GDB. It should - probably be changed to a string, where NULL means the default, - and others are parsed in a file dependent way. */ + structure, allocated in the objfile's storage. + + The section_addr_info structure contains the offset of loadable and + allocated sections, relative to the absolute offsets found in the BFD= . */ void (*sym_offsets) (struct objfile *, const struct section_addr_info *); --=20 2.1.3 --------------ms050802080308060309020002 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature Content-length: 5531 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEH AQAAoIIMqjCCBewwggPUoAMCAQICEQCcTF8c4EKa6GVNC9lZ0VtfMA0GCSqG SIb3DQEBBQUAMDoxETAPBgNVBAoMCEVyaWNzc29uMSUwIwYDVQQDDBxFcmlj c3NvbiBOTCBJbmRpdmlkdWFsIENBIHYyMB4XDTE0MTIxNjE5NTk0NloXDTE3 MTIxNjE5NTk0NVowZjERMA8GA1UECgwIRXJpY3Nzb24xFTATBgNVBAMMDFNp bW9uIE1hcmNoaTEoMCYGCSqGSIb3DQEJARYZc2ltb24ubWFyY2hpQGVyaWNz c29uLmNvbTEQMA4GA1UEBRMHZW1haXNpbjCCASIwDQYJKoZIhvcNAQEBBQAD ggEPADCCAQoCggEBAIUJ3Y1Kka6vwpVQ/RJWY5WcRchKpXoDaydFzm2o7BHE brgv8OuRtM7o9BOmZ2zKhIE8sqF6qieAB28IrELO+3GroV4sQw+lbs4LbjDI wU/DCKX1Y2Jeo+SGaKHMyJ6GPb/HNXrSG9toHjZVavEK1QsXKWmw5txx7i1w lG6iZrUGHT0n1zieZv+/kvoGLid2XITxQwN3qFWDhAv//1e+dWC+yuNiZf6T GagAvSto+Brt7G035UoLmj6TPuquQ6wGPe7NS7owTTTXO1QjRXGobL+SvUd8 fhPZnspi3GvGR6ez8lPLwwLmMR+EjE6eeRW3j+cWySwZHr6ElUXMxEXp3kMC AwEAAaOCAb8wggG7MEgGA1UdHwRBMD8wPaA7oDmGN2h0dHA6Ly9jcmwudHJ1 c3QudGVsaWEuY29tL2VyaWNzc29ubmxpbmRpdmlkdWFsY2F2Mi5jcmwwgYIG CCsGAQUFBwEBBHYwdDAoBggrBgEFBQcwAYYcaHR0cDovL29jc3AyLnRydXN0 LnRlbGlhLmNvbTBIBggrBgEFBQcwAoY8aHR0cDovL2NhLnRydXN0LnRlbGlh c29uZXJhLmNvbS9lcmljc3Nvbm5saW5kaXZpZHVhbGNhdjIuY2VyMCQGA1Ud EQQdMBuBGXNpbW9uLm1hcmNoaUBlcmljc3Nvbi5jb20wVQYDVR0gBE4wTDBK BgwrBgEEAYIPAgMBARIwOjA4BggrBgEFBQcCARYsaHR0cHM6Ly9yZXBvc2l0 b3J5LnRydXN0LnRlbGlhc29uZXJhLmNvbS9DUFMwHQYDVR0lBBYwFAYIKwYB BQUHAwQGCCsGAQUFBwMCMB0GA1UdDgQWBBSkU7Li94HGv+OMwPr25KmDfTGr WDAfBgNVHSMEGDAWgBSxDcrURrevhgLDL28Gyg52cX9LNzAOBgNVHQ8BAf8E BAMCBaAwDQYJKoZIhvcNAQEFBQADggIBAA9Tk3HllgCdNwg47qHvOyoHBGLD kSOfkpt6JvcoHSDxZCPITq/Zh2jZbMFb/+Mx3dTU05vKxZEM/SD5PmYwEYZ7 6XYda92jpeJAcWwrO9ge1Es2jijoZ4B1Z/vvWCpSRMivyJgaLdWTvnINMb2V 1obTc0gLenubiyoHzbbS7mv7i17kB+e+Q/1Hn6avOsX0qVbO1aXnmOFAZ8Zh 8zsyy113BiTR19H22+PjKIfvWnnLaTqai7wO+mjMW62Ih2pTjC719bdt7tIy Al2trDCPxukzVzWpcV+ntMR/I7ucXB7e7NGa7raUZXI0wrwEx2iBQ9v2FNON SmdVBMyVioB1xMornioRqCY1vpihj9kkU1LfZHjRyW209g/tFuz+0B49Dish Kwhno3IFlWxvCH+yynnLzbbUF7kyYg4H02P9QZ6VqUAsDIAXZcb/sWLl1mKk 79NT5QEujbhVdbjpFX9g0JtgCMJHlS5MpydrYSlQ5zQNc0+XQ57OIYCQYCcE 2Dc6KTWNeTmyQIovNfM01X+GriF7A3dYszBR/kGQ5gQHs35/asND6I1mnJsQ 8F7rfOwbU8yQ/W+0JIzwBmX1i0P777x5txSglea9eRS3h1CRGMBobk7dbwQM Vvn4b1g8eBc95kTt3q3QrFhYoMWQJJIltWJpuwwP1mhbDEh0mWM7x5CmMIIG tjCCBJ6gAwIBAgIRAKAMy8ybmZjs4jpw9HzBwFkwDQYJKoZIhvcNAQEFBQAw NzEUMBIGA1UECgwLVGVsaWFTb25lcmExHzAdBgNVBAMMFlRlbGlhU29uZXJh IFJvb3QgQ0EgdjEwHhcNMTQwNTI3MDc0NjIxWhcNMjQwNTI3MDc0NjIxWjA6 MREwDwYDVQQKDAhFcmljc3NvbjElMCMGA1UEAwwcRXJpY3Nzb24gTkwgSW5k aXZpZHVhbCBDQSB2MjCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIB ANq6U+tfSJZTn4k46qN13HgaeXXsMmGSWShc6A5IEyFboXMZW3lFHso+/6uO 3ZilvB2ipZJhrhU+RL/va+5Chay/PZq9ZZeE9N03OsHfOzlwk7uwojJ34tHL iX/yQoriI+b5DXxfIYXTFO5zlZLdaIxJwlLEQp0g4/zF6EGtodlpusaH07FA cLiIEeTMPRgXcn+8GoFOvtuVHNh/WHePlrupUgcI9/P54ITXvmZF6xcNBEjs u8yJm1VqqK0GXSgAmInJ4Ga8S6ME2wgSBRDolxAUbmfLQRrMvLC/tyXBvuLO 8uChdzpIWt3QPtMYm2R2V1Um0zANhenIUwYCKNPq5/yHaS48jCsOBAU0TIhB nirnZmlEbC6ALqwzGAcQMaMD8LFf1oLlWLUQxEmI4YXqBXdP5XnIcMdIEF5B tUBebzBJMMF9dDB2uj8BeoRPSYbpGl7irYUYFpq4TyocQ7qpHdYASC+NV8VT aTrFnHWqa/CGRdp3GHpkgxfOBvpamOK8udHQYQo2uA3YNd2+j7p4C3jkGG+Z 6RrZOskPEwtaIHLxBiA141dhCy5EScOyNajrAXQupsDnvr2ib2ef+4nObPFv edPWIe57lyj0n3e1rTqTGIBIe9wjNnAA6MqeaTS9HchPtBvOrah/cTWzXzGj wMz0P3UJqTQ2r5EAu12/W5kpAgMBAAGjggG4MIIBtDCBigYIKwYBBQUHAQEE fjB8MC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC50cnVzdC50ZWxpYXNvbmVy YS5jb20wSwYIKwYBBQUHMAKGP2h0dHA6Ly9yZXBvc2l0b3J5LnRydXN0LnRl bGlhc29uZXJhLmNvbS90ZWxpYXNvbmVyYXJvb3RjYXYxLmNlcjASBgNVHRMB Af8ECDAGAQH/AgEAMFUGA1UdIAROMEwwSgYMKwYBBAGCDwIDAQECMDowOAYI KwYBBQUHAgEWLGh0dHBzOi8vcmVwb3NpdG9yeS50cnVzdC50ZWxpYXNvbmVy YS5jb20vQ1BTMEsGA1UdHwREMEIwQKA+oDyGOmh0dHA6Ly9jcmwtMy50cnVz dC50ZWxpYXNvbmVyYS5jb20vdGVsaWFzb25lcmFyb290Y2F2MS5jcmwwHQYD VR0lBBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMA4GA1UdDwEB/wQEAwIBBjAd BgNVHQ4EFgQUsQ3K1Ea3r4YCwy9vBsoOdnF/SzcwHwYDVR0jBBgwFoAU8I9Z OACz9Y+algzV6/p7qhfoExIwDQYJKoZIhvcNAQEFBQADggIBAG4HIGyvrHc9 kEKyYZtxJn9cv7S2dUxuUiegmAvUGHc+JGJyB2jyX7py9an8CsHAxg3BI3Ku 9j0h7DJpXyfrlzmg36XYkNS7Ot0A1UqdjGFrtnIISI+Zj3ywHZudmDF8ktdB ihHAjuk47B/Kg/Z8JhUJ37GGx/KxiIiXg5HMTdOl6mlDbJaTIEGagdRcmH3u 57r5snZ+qdVSg5UxWdhgS2+zPru/vDbPd+91zLTj9GejKXFJ6fEAOLW1j2Ij J0cyDI67d1/OzFTwCK8wYbhopK2wJ9QTKDQuWRuGoyt2d6yzd7WoAS55JE0B It+kXDJGbOaK42H2ifO6ERHbJiEr/oh4KzgdAes+GRjwlSaG2Z0va4Ss5lY6 zfwVCEZYdZcjSDpKB0M5tTQYQeO7QyQPOI6Gb4FXA9ko3sHvAPs4+Pq+UtWj p3y8sYr1vLCER9ePEsgLdCG27mUk9OAijkG6n5oEGOIn+70F+qvKpmm52dZ8 b7DELfbuuk0CrY4p0WxH3bBt6FJkPeZJIB6YNXAYHZi7RcdBjLJh+lawbIYT JFIcoWFHAl0g0/NYsjz3DLhZz4+CrJ6SQSYmp7qDhdJAWPiaq3C+qE/h2DZA Jwoz9uHrZHB8zsZ5JL8sUZ7zgqYmNMN+9PxzasrycTJn96Y63AIZdDq1kIHI w0vF4PBTVMZtMYIDBzCCAwMCAQEwTzA6MREwDwYDVQQKDAhFcmljc3NvbjEl MCMGA1UEAwwcRXJpY3Nzb24gTkwgSW5kaXZpZHVhbCBDQSB2MgIRAJxMXxzg QproZU0L2VnRW18wCQYFKw4DAhoFAKCCAY0wGAYJKoZIhvcNAQkDMQsGCSqG SIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTQxMjE4MTgyNjA0WjAjBgkqhkiG 9w0BCQQxFgQUTxSIKg/S7mL4psNn5Tff8jFcJIAwXgYJKwYBBAGCNxAEMVEw TzA6MREwDwYDVQQKDAhFcmljc3NvbjElMCMGA1UEAwwcRXJpY3Nzb24gTkwg SW5kaXZpZHVhbCBDQSB2MgIRAJxMXxzgQproZU0L2VnRW18wYAYLKoZIhvcN AQkQAgsxUaBPMDoxETAPBgNVBAoMCEVyaWNzc29uMSUwIwYDVQQDDBxFcmlj c3NvbiBOTCBJbmRpdmlkdWFsIENBIHYyAhEAnExfHOBCmuhlTQvZWdFbXzBs BgkqhkiG9w0BCQ8xXzBdMAsGCWCGSAFlAwQBKjALBglghkgBZQMEAQIwCgYI KoZIhvcNAwcwDgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAcGBSsO AwIHMA0GCCqGSIb3DQMCAgEoMA0GCSqGSIb3DQEBAQUABIIBAH2OhDwtr71e ZqanVgqcB800XZeFXdcgslXU7NqTmKAFwfgJmXIfQ41Wm6Pv3llGOJQODZTD OzOGFDv2ac8Ey1CZS5Xb4i2d8TelHAOWGiuVDDxTGfWei/3DxbTqykOuLsNl jW9LPHhRI6JudmG4Zz1aE4c7EVMTN37zKblVae7MzLrU+V3BjVVNkAmCZVpA nfAhhRHNh1umwPa6BHVAaklFONSRpZ2i7H67DjrC5WLnbqTskT+AJquLSKJf hDLxngirg33wr5vG0QDoNBOCbk9LLSx21JkoybbHTvOPorpsEa4sB9D/JSwE M4TXLaqtCwNaS/PzMftwGWOdI74WaxwAAAAAAAA= --------------ms050802080308060309020002--