From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19225 invoked by alias); 15 Dec 2014 13:22:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19214 invoked by uid 89); 15 Dec 2014 13:22:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Dec 2014 13:22:22 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBFDMI8Y027752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 15 Dec 2014 08:22:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBFDMHRg027587; Mon, 15 Dec 2014 08:22:17 -0500 Message-ID: <548EE088.20506@redhat.com> Date: Mon, 15 Dec 2014 13:22:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [RFA/Linux] Ask kernel to kill inferior when GDB terminates References: <1415984034-27122-1-git-send-email-brobecker@adacore.com> <54663729.6010708@redhat.com> <20141114173255.GD5774@adacore.com> <20141119092547.GP5774@adacore.com> <546C69D4.5090300@redhat.com> <20141213162757.GL5457@adacore.com> In-Reply-To: <20141213162757.GL5457@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00385.txt.bz2 On 12/13/2014 04:27 PM, Joel Brobecker wrote: >>>>> I could see this making some sense when GDB has spawned the process, >>>>> but it seems harsh when GDB has attached to the process instead >>>>> of spawning it? > [...] >>> I will adapt my patch when I have a moment. > > Just took a look, and it's not clear to me what the best way to do that > might me. For native GDB, it'd be fairly easy, if I could just add > an "attaching_p" parameter to "linux_enable_event_reporting", then > I could just mask PTRACE_O_EXITKILL out if nonzero. In linux-nat.c, > it's fairly easy to provide that info. However, things are not so > clear in the gdbserver case, because linux_enable_event_reporting > is performed during the event handling conditional on > child->must_set_ptrace_flags: > > if (WIFSTOPPED (wstat) && child->must_set_ptrace_flags) > { > linux_enable_event_reporting (lwpid); > child->must_set_ptrace_flags = 0; > } > > I think the only clean way to do this would be to add another > field in struct lwp_info such as "attaching_p" which we would > set to 1 in the attaching case only. I think we can get by without adding a new field. The process_info structure has the "process->attached" field already. We could check that here. Alternatively, must_set_ptrace_flags could be a tri-state instead of a boolean, which would be cheaper. > > Does this seem reasonable? > > Thanks, > Thanks, Pedro Alves