From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 2/2] Provide completer for "info registers"
Date: Mon, 15 Dec 2014 12:41:00 -0000 [thread overview]
Message-ID: <548ED703.9020305@redhat.com> (raw)
In-Reply-To: <87388kn0zt.fsf@br87z6lw.de.ibm.com>
On 12/12/2014 07:04 PM, Andreas Arnez wrote:
> On Fri, Dec 12 2014, Doug Evans wrote:
>
>> I'm seeing the following new failure on amd64-linux:
>>
>> (gdb) complete info registers ^M
>> info registers ah^M
>> info registers al^M
>> ...
>> info registers ymm9^M
>> info registers ymm9h^M
>> (gdb) FAIL: gdb.base/completion.exp: complete 'info registers '
>
> Oops. This is because the user registers have 3-digit numbers and thus
> occupy the first column in the output of "maint print user-registers".
> This doesn't match the latest version of the regexp in completion.exp.
>
> In fact, this is a useful finding, because the output of "maint print
> user-registers" should actually be indented.
>
> Here's a suggested fix.
OK, thanks.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2014-12-15 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 11:49 [PATCH v4 0/2] Provide useful " Andreas Arnez
2014-12-11 11:49 ` [PATCH v4 2/2] Provide " Andreas Arnez
2014-12-12 13:20 ` Pedro Alves
2014-12-12 15:20 ` Andreas Arnez
2014-12-12 15:30 ` Pedro Alves
2014-12-12 17:45 ` Doug Evans
2014-12-12 19:04 ` Andreas Arnez
2014-12-15 12:41 ` Pedro Alves [this message]
2014-12-11 11:49 ` [PATCH v4 1/2] Add new GDB command "maint print user-registers" Andreas Arnez
2014-12-12 13:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548ED703.9020305@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox