Re: [PATCH v4 12/14] add linux_infcall_mmap

Ulrich Weigand
2014-12-15T12:41:43Z

Jan Kratochvil wrote:

> + enum
> + {
> + ARG_ADDR, ARG_LENGTH, ARG_PROT, ARG_FLAGS, ARG_FD, ARG_OFFSET, ARG_MAX
> + };
> + struct value *arg[ARG_MAX];

This causes:
/home/uweigand/dailybuild/spu-tc-2014-12-13/binutils-gdb-head/binutils-gdb/gdb/linux-tdep.c: In function 'linux_infcall_mmap':
/home/uweigand/dailybuild/spu-tc-2014-12-13/binutils-gdb-head/binutils-gdb/gdb/linux-tdep.c:1945: error: expected identifier before numeric constant

on my RHEL 5 build system, presumably because ARG_MAX is defined
(to a numeric constant) by a system header.

Can we give those more distinctive names?

Thanks,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com