From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-118245-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20824 invoked by alias); 12 Dec 2014 13:20:13 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20811 invoked by uid 89); 12 Dec 2014 13:20:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Dec 2014 13:20:11 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBCDK8Pi005788	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Fri, 12 Dec 2014 08:20:08 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBCDK7B1018713;	Fri, 12 Dec 2014 08:20:07 -0500
Message-ID: <548AEB86.60809@redhat.com>
Date: Fri, 12 Dec 2014 13:20:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 2/2] Provide completer for "info registers"
References: <1418298589-23120-1-git-send-email-arnez@linux.vnet.ibm.com> <1418298589-23120-3-git-send-email-arnez@linux.vnet.ibm.com>
In-Reply-To: <1418298589-23120-3-git-send-email-arnez@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-12/txt/msg00278.txt.bz2

On 12/11/2014 11:49 AM, Andreas Arnez wrote:

> +set regs_output [capture_command_output "mt print registers" \
> +		     ".*Name.*Nr.*Rel.*Offset.*Size.*Type.\[^\n\]*\n"]
> +append regs_output "\n"
> +append regs_output [capture_command_output "mt print reggroups" \
> +			".*Group.*Type\[^\n]*\n"]
> +set all_regs {}
> +foreach {-> reg} [regexp -all -inline -line {^\s+(\w+\S*)} $regs_output] {

This "->" here confused me a little.  AFAIK, $- is a more common "don't care"
variable (and what foreach's documentation suggests).  Any reason to
pick -> instead?

Also, why do we need the "\S*" ?  I'd assume {^\s+(\w+)} works just as well.

> +    lappend all_regs $reg
> +}
> +
> +set regs_output [capture_command_output "mt print user-registers" \
> +		     ".*Nr.*Name\[^\n]*\n"]
> +foreach {-> reg} [regexp -all -inline -line {\d+\s+(\w+\S*)} $regs_output] {

Likewise.

Otherwise this looks good to me.

Thanks,
Pedro Alves