From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27307 invoked by alias); 12 Dec 2014 12:04:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27291 invoked by uid 89); 12 Dec 2014 12:04:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Dec 2014 12:04:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBCC4dkZ008167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Dec 2014 07:04:39 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBCC4cdk029605; Fri, 12 Dec 2014 07:04:38 -0500 Message-ID: <548AD9D5.1060303@redhat.com> Date: Fri, 12 Dec 2014 12:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andreas Arnez , gdb-patches@sourceware.org Subject: Re: [PATCH v4 1/4] gdbserver: Rephrase loops in regsets_fetch/store_inferior_registers References: <1418379431-14407-1-git-send-email-arnez@linux.vnet.ibm.com> <1418379431-14407-2-git-send-email-arnez@linux.vnet.ibm.com> In-Reply-To: <1418379431-14407-2-git-send-email-arnez@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00273.txt.bz2 On 12/12/2014 10:16 AM, Andreas Arnez wrote: > Replace the while-loops in linux-low.c that iterate over regsets by > for-loops. This makes it clearer what is iterated over. Also, since > "continue" now moves on to the next iteration without having to > increment the regset pointer first, the code is slightly reduced. > > In case of EIO the old code did not increment the regset pointer, but > iterated over the same (now disabled) regset again. This extra > iteration is now avoided. Nice. Looks good to me. Thanks, Pedro Alves