From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27476 invoked by alias); 12 Dec 2014 11:35:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27466 invoked by uid 89); 12 Dec 2014 11:35:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Dec 2014 11:35:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBCBZnBS032699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Dec 2014 06:35:49 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBCBZk65003900; Fri, 12 Dec 2014 06:35:47 -0500 Message-ID: <548AD312.6010707@redhat.com> Date: Fri, 12 Dec 2014 11:35:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yao Qi , Doug Evans CC: "gdb-patches@sourceware.org" Subject: Re: [RFC] Run tests in sub dir of testsuite/ References: <1418266428-13166-1-git-send-email-yao@codesourcery.com> <54890CDE.8050405@codesourcery.com> In-Reply-To: <54890CDE.8050405@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00271.txt.bz2 On 12/11/2014 03:17 AM, Yao Qi wrote: > On 12/11/2014 11:05 AM, Doug Evans wrote: >> Is there intended to be a followup patch to remove >> all the makefiles in testsuite/ except testsuite/Makefile.in? >> >> [I realize this patch is just RFC. >> I just want to understand where this is headed.] > > Yes, that is what I want to do in next step. > >> >> btw, while it might be cleaner to move gdb.log,gdb.sum into >> the subdirs, it's not necessary. >> I can update my build scripts, but if we're going >> to be affecting a lot of build scripts then I'd >> reconsider. > > I am fine to leave gdb.log and gdb.sum in testsuite/. The reason I move > them into testsuite/$OUTPUTSDIR/ is to make $OUTPUTSDIR self-contained. > Either way is fine to me, and I don't have a strong > opinion on this. I tend to think it's better to leave them be if there's no real good reason to move them. Note that "make clean" doesn't delete gdb.sum/gdb.log, "make distclean" does. If "make clean" is just going to be "rm -f $subdirs", then to preserve that it seems simplest to keep gdb.sum and gdb.log out of the subdirs. (nit, on "sequential-tests"/"parallel-tests" -- it's the run, not the tests that are sequential or parallel. I'd suggest dropping "-tests" from the dir names or use "-run", to avoid potential confusion.) Thanks, Pedro Alves