From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13112 invoked by alias); 12 Dec 2014 11:15:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13102 invoked by uid 89); 12 Dec 2014 11:15:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Dec 2014 11:15:43 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBCBFcfL020379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Dec 2014 06:15:39 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBCBFabx004809; Fri, 12 Dec 2014 06:15:37 -0500 Message-ID: <548ACE58.90507@redhat.com> Date: Fri, 12 Dec 2014 11:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yao Qi , David Taylor CC: "gdb-patches@sourceware.org" Subject: Re: RFA 0/2 fix for bug with large structure offsets References: <18829.1416329565@usendtaylorx2l> <23959.1418329569@usendtaylorx2l> <87zjaty0ze.fsf@codesourcery.com> In-Reply-To: <87zjaty0ze.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00270.txt.bz2 On 12/12/2014 03:56 AM, Yao Qi wrote: > David Taylor writes: > >> In the slightly over three weeks since I posted this and the two related >> parts, I have seen only two replies off list, nothing on list. >> >> This bug is affecting us and I'd like some version of a fix for it to go >> in. Any chance? > > It is worried that we can't verify the type width change like this. Hmm. Is it really a big problem though? What's the worse failure mode if we miss converting some code path? It seems that even if that happens, we won't be worse than today? > Personally, I don't see the point GDB-switch-to-C++ block the changes, > either from your patch or from Fedora GDB's patches, although I agree > that it is easier to do sanity check in C++. Agreed. > If it is practical to turn on -Wconversion and people here agree to do > so, we can do it first to pave the way for your patch, and convince > people your patch is safe enough. Last time I tried turning > -Wconversion on, it causes a huge number of warnings. :-/ I'm not even sure it makes sense to have -Wconversion (or its variants) block this? If we agree on the types to use, then it seems to me it's more useful to push the patches in than hold them up. Thanks, Pedro Alves