From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8796 invoked by alias); 11 Dec 2014 17:44:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8711 invoked by uid 89); 11 Dec 2014 17:44:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Dec 2014 17:44:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBBHhvrZ004970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Dec 2014 12:43:58 -0500 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBBHhuWk029198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 11 Dec 2014 12:43:56 -0500 Message-ID: <5489D7DC.3060806@redhat.com> Date: Thu, 11 Dec 2014 17:44:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] Commit f64e188b5 broke core file support in gdb References: <1418246544-28431-1-git-send-email-keiths@redhat.com> <20141210220453.GA4283@bubble.grove.modra.org> In-Reply-To: <20141210220453.GA4283@bubble.grove.modra.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00250.txt.bz2 On 12/10/2014 02:04 PM, Alan Modra wrote: > On Wed, Dec 10, 2014 at 01:22:24PM -0800, Keith Seitz wrote: >> * elf.c (elf_parse_notes): Define convenience macro >> GROKER_ELEMENT to add string lengths to 'grokers'. >> Use grokers.len instead of sizeof in string comparisons. > > OK, thanks. > I've pushed this. Thank you for the review, Alan! Keith