From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7397 invoked by alias); 10 Dec 2014 17:23:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7381 invoked by uid 89); 10 Dec 2014 17:23:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Dec 2014 17:23:40 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBAHNZTC006894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Dec 2014 12:23:36 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBAHNXnZ007176; Wed, 10 Dec 2014 12:23:34 -0500 Message-ID: <54888195.3060102@redhat.com> Date: Wed, 10 Dec 2014 17:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Eli Zaretskii CC: patrick@parcs.ath.cx, gdb-patches@sourceware.org Subject: Re: [PATCH] Append to input history file instead of overwriting it References: <1417226462-11254-1-git-send-email-patrick@parcs.ath.cx> <54808956.9070507@redhat.com> <54818CCE.5010701@redhat.com> <54887AB5.3000101@redhat.com> <83a92vv37l.fsf@gnu.org> In-Reply-To: <83a92vv37l.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00214.txt.bz2 On 12/10/2014 05:12 PM, Eli Zaretskii wrote: >> Date: Wed, 10 Dec 2014 16:54:13 +0000 >> From: Pedro Alves >> CC: gdb-patches@sourceware.org >> >> Is it that hard to do though? How about temporarily renaming the >> history file to something that includes gdb's PID (and would not a >> file name a user would use in practice) while we append >> to it, and then (atomically) rename it back? Something like: >> >> #1 - move $HISTFILE -> $HISTFILE-gdb$PID~ >> #2 - write/append history to $HISTFILE-gdb$PID~ >> #3 - move $HISTFILE-gdb$PID~ -> $HISTFILE > > You cannot portably rename a file someone writes to, unless you are > willing to limit this to Posix filesystems. The way I've proposed, no gdb would be actually writing directly to $HISTFILE, only reading. Is it a problem still? Not considering someone manually opening the file for writing, but in that case the system that would fail the rename would fail the write-in-place too. Thanks, Pedro Alves