From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21477 invoked by alias); 7 Dec 2014 22:31:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21453 invoked by uid 89); 7 Dec 2014 22:31:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f50.google.com Received: from mail-pa0-f50.google.com (HELO mail-pa0-f50.google.com) (209.85.220.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 07 Dec 2014 22:31:54 +0000 Received: by mail-pa0-f50.google.com with SMTP id bj1so4032254pad.9 for ; Sun, 07 Dec 2014 14:31:52 -0800 (PST) X-Received: by 10.70.37.35 with SMTP id v3mr15495194pdj.4.1417991512663; Sun, 07 Dec 2014 14:31:52 -0800 (PST) Received: from ShengShiZhuChengdeMacBook-Pro.local ([223.72.65.106]) by mx.google.com with ESMTPSA id pk1sm34643784pdb.78.2014.12.07.14.31.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Dec 2014 14:31:51 -0800 (PST) Message-ID: <5484D6EC.6080306@gmail.com> Date: Sun, 07 Dec 2014 22:31:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue References: <5447CF8A.6020603@gmail.com> <544AD714.8040506@gmail.com> <20141123063849.GA7636@adacore.com> <5471E3D5.10006@gmail.com> In-Reply-To: <5471E3D5.10006@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00170.txt.bz2 After consult parisc kernel members, I found the related document for it, I guess, it can be as our proof for this patch: https://parisc.wiki.kernel.org/images-parisc/7/73/Parisc2.0.pdf For me, my original comments need be improved: need mention about STH, and maybe also need consider about additional related instructions of parisc 2.0 (STDA, STWA, STBY, STDBY) in our source code. Welcome any suggestions, ideas, and completions. Thanks. On 11/23/14 21:40, Chen Gang wrote: > On 11/23/2014 02:38 PM, Joel Brobecker wrote: >> Chen, >> >>> Is this patch OK, it is part of checking saving registers in the stack, >>> it tries to recognize the saving instructions "stb, stw(m), or std", so >>> can continue checking. >>> >>> Excuse me, I have no related environments for a test, I assumed that the >>> original author knew about the working flow, then wrote the related >>> function. >>> >>> If need additional analyzing, please let me know (better to let me know >>> what I need try, next). >> >> Thank you for the patch, but lack of access to an environment where >> you can test is an issue. I would be an entirely different context >> if the fix was obvious, but it isn't unless perhaps you start >> opening HP-PA assembly manuals; and I don't honestly see much interest >> in HP-PA anymore. >> > > I shall try to find the related assembly reference (although it is not > quite easy for me, and may be fail to get it), or get parisc related > members confirmation. > > Hope I can get related proof (related documents, or related members > confirmation) within next month (2014-12-31), although I am not quite > sure whether I can finish or not. > >> And if you do not have access to an environment for a test, how did >> you come about this issue? Does the lack of evironment mean lack of >> the software (tcl, expect, dejagnu), or lack of hardware? >> > > It is lack of hardware and related software. And I found it firstly by > gcc5 compiler warning, then read through the code (together with some > gdb members), found it should be an issue. > > > Thanks. > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed