From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6201 invoked by alias); 4 Dec 2014 17:07:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6123 invoked by uid 89); 4 Dec 2014 17:07:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Dec 2014 17:07:04 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB4H6xsO028674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Dec 2014 12:07:00 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB4H6vcZ015658; Thu, 4 Dec 2014 12:06:58 -0500 Message-ID: <548094B1.8050708@redhat.com> Date: Thu, 04 Dec 2014 17:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't enable gdbtk in testsuite References: <1416903049-30419-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1416903049-30419-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00101.txt.bz2 On 11/25/2014 08:10 AM, Yao Qi wrote: > When I skim configure.ac and Makefile.in in gdb/testsuite, I happen to > see that directory gdb.gdbtk is added to subdirs, however it doesn't > exist. gdb/testsuite/gdb.gdbtk was removed by the patch below, > > [rfa] git repo fixup: delete gdb/testsuite/gdb.gdbtk > http://thread.gmane.org/gmane.comp.gdb.patches/61489 That patch removed it from the git repo, mirroring how CVS modules worked. In CVS, if you checkout the "gdb" module, you don't get the gdbtk dirs, but if you checkout the insight module instead, you get everything gdb, plus the insight bits: src/gdb/gdbtk subdir, src/gdb/testsuite/gdb.gdbtk/, and maybe other bits. So removing the testsuite support for gdbtk doesn't seem like the right thing to do. Particularly since we still have the gdbtk bits in gdb/configure.ac. IOW, I don't see how src/gdb/testsuite/gdb.gdbtk/ not being around is different from src/gdb/gdbtk/ not being around. We should either keep all support for gdbtk, or remove all of it. Thanks, Pedro Alves