From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22512 invoked by alias); 4 Dec 2014 13:29:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22502 invoked by uid 89); 4 Dec 2014 13:29:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Dec 2014 13:29:44 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB4DTdIA009501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Dec 2014 08:29:39 -0500 Received: from x220.homelab.tallawa.org ([10.3.112.16]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB4DTZB9001591 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 4 Dec 2014 08:29:37 -0500 Message-ID: <548061BE.2090604@redhat.com> Date: Thu, 04 Dec 2014 13:29:00 -0000 From: Cleber Rosa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org, cleber@redhat.com Subject: Re: [PATCH 2/2] Function attributes: use shorter versions of the format macros References: <1417449499-23681-1-git-send-email-crosa@redhat.com> <1417449499-23681-2-git-send-email-crosa@redhat.com> <20141203103111.GB7899@adacore.com> In-Reply-To: <20141203103111.GB7899@adacore.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-12/txt/msg00088.txt.bz2 On 12/03/2014 07:31 AM, Joel Brobecker wrote: >> For consistency sake, use the shorter versions of the function attribute >> format macros. > Same as in patch #1, please include the ChangeLog entry in the > commit's revision log. > > It would be good also to explain in the revision log consistency > with what, becuase GDB uses nearly exclusively the form that you > are removing. I know the answer, now, but it took me some time to > figure it out. Sure! BTW, thanks for the feedback and help. They are certainly helpful here, and will be even more in another upcoming patchset. > >> +2014-12-01 Cleber Rosa >> + >> + * ada-lang.c: use shorter versions of function attributes macros. >> + * cli-out.c: Likewise. >> + * common/agent.c: Likewise. >> + * common/buffer.h: Likewise. >> + * common/common-debug.h: Likewise. >> + * common/common-exceptions.h: Likewise. >> + * common/common-utils.h: Likewise. >> + * common/errors.h: Likewise. >> + * complaints.h: Likewise. >> + * disasm.c: Likewise. >> + * exceptions.h: Likewise. >> + * language.h: Likewise. >> + * monitor.c: Likewise. >> + * parser-defs.h: Likewise. >> + * serial.h: Likewise. >> + * ui-out.h: Likewise. >> + * utils.h: Likewise. > Approved. > > Thank you,