From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99985 invoked by alias); 19 Sep 2017 18:29:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99976 invoked by uid 89); 19 Sep 2017 18:29:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:940 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Sep 2017 18:29:11 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C9B77F3E5; Tue, 19 Sep 2017 18:29:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9C9B77F3E5 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 841C25D6A3; Tue, 19 Sep 2017 18:29:09 +0000 (UTC) Subject: Re: [PATCH v3] Add a 'starti' command. To: John Baldwin References: <20170911220803.73819-1-jhb@FreeBSD.org> <7b165874-88ec-0ef2-50c5-9eb7b19eeb53@redhat.com> <19338806.QVLJa9ilSl@ralph.baldwin.cx> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <5479424e-9777-0754-efe8-0523caef1bdc@redhat.com> Date: Tue, 19 Sep 2017 18:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <19338806.QVLJa9ilSl@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00469.txt.bz2 On 09/19/2017 06:49 PM, John Baldwin wrote: > Hmm, how about: > > enum run_how > { > /* Run program without any explicit stop during startup. */ > RUN_NORMAL, Sounds fine. >> You have a "\n" in the middle of some lines above. Was that intended? >> I'd expect to see instead lines broken at \n, ending with \n\ . > > Those were just copy and pasted from the run help. I think they were there > to avoid overflowing 80 columns in the source. I've rewrapped the text so > that newlines are at the end. Thanks. >> Space before parens, line break after return type. >> We follow GNU convention in tests too, unless different syntax is >> relevant for the test. > > Ok. (Ironically I copied both the spurious #include and bad style > from start.c.) Yeah, sorry about that. It was only in recent years that we started following that rule; older tests will be using random styles. Thanks, Pedro Alves