From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9694 invoked by alias); 23 Nov 2014 13:40:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9683 invoked by uid 89); 23 Nov 2014 13:40:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f179.google.com Received: from mail-pd0-f179.google.com (HELO mail-pd0-f179.google.com) (209.85.192.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 23 Nov 2014 13:40:52 +0000 Received: by mail-pd0-f179.google.com with SMTP id w10so8173158pde.24 for ; Sun, 23 Nov 2014 05:40:51 -0800 (PST) X-Received: by 10.68.217.70 with SMTP id ow6mr23788022pbc.93.1416750051122; Sun, 23 Nov 2014 05:40:51 -0800 (PST) Received: from [192.168.1.101] ([223.72.65.89]) by mx.google.com with ESMTPSA id jd1sm9785594pbd.49.2014.11.23.05.40.47 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sun, 23 Nov 2014 05:40:49 -0800 (PST) Message-ID: <5471E3D5.10006@gmail.com> Date: Sun, 23 Nov 2014 13:40:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org, Andreas Schwab Subject: Re: [PATCH v2] gdb/hppa-tdep.c: Fix logical working flow typo issue References: <5447CF8A.6020603@gmail.com> <544AD714.8040506@gmail.com> <20141123063849.GA7636@adacore.com> In-Reply-To: <20141123063849.GA7636@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00569.txt.bz2 On 11/23/2014 02:38 PM, Joel Brobecker wrote: > Chen, > >> Is this patch OK, it is part of checking saving registers in the stack, >> it tries to recognize the saving instructions "stb, stw(m), or std", so >> can continue checking. >> >> Excuse me, I have no related environments for a test, I assumed that the >> original author knew about the working flow, then wrote the related >> function. >> >> If need additional analyzing, please let me know (better to let me know >> what I need try, next). > > Thank you for the patch, but lack of access to an environment where > you can test is an issue. I would be an entirely different context > if the fix was obvious, but it isn't unless perhaps you start > opening HP-PA assembly manuals; and I don't honestly see much interest > in HP-PA anymore. > I shall try to find the related assembly reference (although it is not quite easy for me, and may be fail to get it), or get parisc related members confirmation. Hope I can get related proof (related documents, or related members confirmation) within next month (2014-12-31), although I am not quite sure whether I can finish or not. > And if you do not have access to an environment for a test, how did > you come about this issue? Does the lack of evironment mean lack of > the software (tcl, expect, dejagnu), or lack of hardware? > It is lack of hardware and related software. And I found it firstly by gcc5 compiler warning, then read through the code (together with some gdb members), found it should be an issue. Thanks. -- Chen Gang Open share and attitude like air water and life which God blessed