From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117723-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14947 invoked by alias); 21 Nov 2014 13:17:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14936 invoked by uid 89); 21 Nov 2014 13:17:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Nov 2014 13:17:17 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sALDHDhG019800	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Fri, 21 Nov 2014 08:17:13 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sALDHBEr013609;	Fri, 21 Nov 2014 08:17:11 -0500
Message-ID: <546F3B56.8040703@redhat.com>
Date: Fri, 21 Nov 2014 13:17:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Yao Qi <yao@codesourcery.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/7] Include alloca.h unconditionally
References: <1416057612-16155-1-git-send-email-yao@codesourcery.com>	<1416057612-16155-4-git-send-email-yao@codesourcery.com>	<546F2E3E.50504@redhat.com> <87bno0g0vl.fsf@codesourcery.com>
In-Reply-To: <87bno0g0vl.fsf@codesourcery.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-11/txt/msg00515.txt.bz2

On 11/21/2014 01:05 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
>>> -#ifdef HAVE_ALLOCA_H
>>> -#include <alloca.h>
>>> -#endif
>>>  /* On some systems such as MinGW, alloca is declared in malloc.h
>>>     (there is no alloca.h).  */
>>>  #if HAVE_MALLOC_H
>>
>> We should remove the malloc.h includes too then, and the check
>> for malloc.h in configure.ac.  It's only included for alloca.
> 
> That is a good point.  The patch below is to do so.

Thanks.  This version looks good to me.

Pedro Alves