From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21873 invoked by alias); 21 Nov 2014 12:21:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21850 invoked by uid 89); 21 Nov 2014 12:21:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 21 Nov 2014 12:21:24 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sALCLKOe003322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Nov 2014 07:21:21 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sALCLICx029713; Fri, 21 Nov 2014 07:21:19 -0500 Message-ID: <546F2E3E.50504@redhat.com> Date: Fri, 21 Nov 2014 12:21:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Include alloca.h unconditionally References: <1416057612-16155-1-git-send-email-yao@codesourcery.com> <1416057612-16155-4-git-send-email-yao@codesourcery.com> In-Reply-To: <1416057612-16155-4-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00510.txt.bz2 On 11/15/2014 01:20 PM, Yao Qi wrote: > diff --git a/gdb/gdbserver/gdbreplay.c b/gdb/gdbserver/gdbreplay.c > index c70abef..ffe7392 100644 > --- a/gdb/gdbserver/gdbreplay.c > +++ b/gdb/gdbserver/gdbreplay.c > @@ -48,9 +48,9 @@ > #if HAVE_NETINET_TCP_H > #include > #endif > -#if HAVE_ALLOCA_H > + > #include > -#endif > + > #if HAVE_MALLOC_H > #include > #endif ... > diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h > index cac73e9..857875a 100644 > --- a/gdb/gdbserver/server.h > +++ b/gdb/gdbserver/server.h > @@ -29,9 +29,6 @@ gdb_static_assert (sizeof (CORE_ADDR) >= sizeof (void *)); > > #include "version.h" > > -#ifdef HAVE_ALLOCA_H > -#include > -#endif > /* On some systems such as MinGW, alloca is declared in malloc.h > (there is no alloca.h). */ > #if HAVE_MALLOC_H We should remove the malloc.h includes too then, and the check for malloc.h in configure.ac. It's only included for alloca. Thanks, Pedro Alves