From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117521-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11643 invoked by alias); 14 Nov 2014 15:53:03 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 11623 invoked by uid 89); 14 Nov 2014 15:53:02 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Nov 2014 15:53:01 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAEFqvT2027765	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Fri, 14 Nov 2014 10:52:57 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAEFqseh027712;	Fri, 14 Nov 2014 10:52:56 -0500
Message-ID: <54662556.1090501@redhat.com>
Date: Fri, 14 Nov 2014 15:53:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Sergio Durigan Junior <sergiodj@redhat.com>,        GDB Patches <gdb-patches@sourceware.org>
CC: Gabriel Krisman Bertazi <gabriel@krisman.be>
Subject: Re: [PATCH 1/3] Making syscall information be per-arch, instead of global
References: <1415837887-28888-1-git-send-email-sergiodj@redhat.com> <1415837887-28888-2-git-send-email-sergiodj@redhat.com>
In-Reply-To: <1415837887-28888-2-git-send-email-sergiodj@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-11/txt/msg00313.txt.bz2

On 11/13/2014 12:18 AM, Sergio Durigan Junior wrote:

> 	(xml_init_syscalls_info): Likewise.

Should mention the dropped const.

>  xml_init_syscalls_info (const char *filename)
>  {
>    char *full_file;
>    char *dirname;
> -  struct syscalls_info *sysinfo;
> +  struct syscalls_info *syscalls_info;
>    struct cleanup *back_to;
>  
>    full_file = xml_fetch_content_from_file (filename, gdb_datadir);
> @@ -266,41 +265,47 @@ xml_init_syscalls_info (const char *filename)
>    if (dirname != NULL)
>      make_cleanup (xfree, dirname);
>  
> -  sysinfo = syscall_parse_xml (full_file,
> +  syscalls_info = syscall_parse_xml (full_file,
>  			       xml_fetch_content_from_file, dirname);

The line after needs a reindent.

>    do_cleanups (back_to);
>  
> -  return sysinfo;
> +  return syscalls_info;
>  }
>  

> -  have_initialized_sysinfo = 1;
> +  /* If there was some error reading the XML file, we initialize
> +     gdbarch->syscalls_info anyway, in order to store information
> +     about our attempt.  */
> +  if (syscalls_info == NULL)
> +      syscalls_info = allocate_syscalls_info ();

Indentation here looks odd.

>
> -  if (sysinfo == NULL)
> +  if (syscalls_info->syscalls == NULL)
>      {

Otherwise looks good.

Thanks for doing this.

Thanks,
Pedro Alves