From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16866 invoked by alias); 14 Nov 2014 14:42:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16856 invoked by uid 89); 14 Nov 2014 14:42:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 14 Nov 2014 14:42:24 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sAEEgI99028565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 14 Nov 2014 09:42:18 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sAEEgF12013647; Fri, 14 Nov 2014 09:42:15 -0500 Message-ID: <546614C6.30509@redhat.com> Date: Fri, 14 Nov 2014 14:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Eli Zaretskii CC: yao@codesourcery.com, gdb-patches@sourceware.org, gregory.0xf0@gmail.com, brobecker@adacore.com Subject: Re: gnulib's errno module was imported References: <87oasaibe6.fsf@codesourcery.com> <5465EBAD.3070108@redhat.com> <87fvdmhr5o.fsf@codesourcery.com> <546601BD.7020700@redhat.com> <83ioihj1kj.fsf@gnu.org> In-Reply-To: <83ioihj1kj.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00311.txt.bz2 On 11/14/2014 02:31 PM, Eli Zaretskii wrote: >> From: Pedro Alves >> That was actually my first approach, but then: >> >> - I thought that having a central place to handle this >> and to put the comment was cleaner than repeating the fix >> in multiple places. >> - That won't build on systems that EILSEQ and ENOENT are >> defined to the same value (two switch cases with the same value). >> Not sure there are any such systems, but given iconv.h's practice... > > The last one is easy: > > case EILSEQ: > +#if EILSEQ != ENOENT > + case ENOENT: > +#endif Agreed, but then having to do that in multiple places seems even uglier. :-) Thanks, Pedro Alves