From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11793 invoked by alias); 13 Nov 2014 19:06:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11782 invoked by uid 89); 13 Nov 2014 19:06:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Nov 2014 19:06:24 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Xozin-000206-96 from Don_Breazeal@mentor.com ; Thu, 13 Nov 2014 11:06:21 -0800 Received: from [172.30.1.21] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server (TLS) id 14.3.181.6; Thu, 13 Nov 2014 11:06:20 -0800 Message-ID: <5465012C.9060708@codesourcery.com> Date: Thu, 13 Nov 2014 19:06:00 -0000 From: "Breazeal, Don" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH 06/16 v3] Extended-remote Linux follow fork References: <1408580964-27916-1-git-send-email-donb@codesourcery.com> <1414798134-11536-4-git-send-email-donb@codesourcery.com> <5464AB62.5040100@redhat.com> <5464FE11.1080001@codesourcery.com> <5464FF7D.6060103@redhat.com> In-Reply-To: <5464FF7D.6060103@redhat.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00279.txt.bz2 On 11/13/2014 10:59 AM, Pedro Alves wrote: > On 11/13/2014 06:53 PM, Breazeal, Don wrote: >> My initial approach was to do just that, but I ended up with >> linux-specific code in remote.c (the code that lives in linux-nat.c >> for the native implementation). I guess the direction of recent >> changes would be to put that code into a common file in gdb/nat, >> if possible. Would that be the approach you would recommend? > > I'm not seeing what would be linux-specific? On remote_follow_fork > fork, we switch the current remote thread to gdb's current > thread (either parent or child), by > calling 'set_general_thread (inferior_ptid);' > And then if we need to detach parent or child, we detach it with > the D;PID packet. > > Thanks, > Pedro Alves > I don't recall the details at this point. I'll proceed with your recommendation, assuming I don't need any common code, and if I run into a problem I'll post a question about it. Thanks --Don