From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id E0FD8385E830 for ; Fri, 22 May 2020 20:28:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E0FD8385E830 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-BoY2WNxlPiC_KVafuG2hsg-1; Fri, 22 May 2020 16:28:18 -0400 X-MC-Unique: BoY2WNxlPiC_KVafuG2hsg-1 Received: by mail-wr1-f70.google.com with SMTP id g10so4811788wrr.10 for ; Fri, 22 May 2020 13:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=V5LIixu9ECzMHSg2CJfr7NZB0K4d7XPFxDuxmGbTK1Y=; b=fQSLe+hNZPeRs27UZ8zTkktvu6LcTmvtsZUZ8Ci8517DR506prforjIeEQm1vYqa6e rLunu7pygDGIwVaOOgZvGLTmfP7+J4wbsJEYrbiyRPyPXsext0h+pPRN1WifRavmjv2r Ju4Mz9u+1unxjdukroihIPvHQBwdCbhJDI0aI6CAgPDcfHmghLzD/NjcWmxBsN/Zi5B6 YsiitPAcgB5KKWscxdTE6Aow+Y7BMUxq1zwo77saT02noowsYdkAhJkCABkW4gWHDKYz SHw6CNXNUvIrROLVA4mJYhx/cYHv11EhEy/hQ52+YeD6M95NhB2EbdIOQT69MP/z/3zr hJNw== X-Gm-Message-State: AOAM532Dvc4CZ5f04Z+DjsibPtwq/qkfBJdagla+sfL2yOxVUnmsd+qV chwN5eN0PGfBeCmf8aiFX4JPGFn2cWZDcQz0pHyRFzR1df9rxwxs1XebSBc6PCSa4tKYbVqblb4 cctaXf1BQu+w0IUPJDEeSqA== X-Received: by 2002:a7b:caf2:: with SMTP id t18mr14265551wml.35.1590179297523; Fri, 22 May 2020 13:28:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU+4TWpQ6BOEKr7IjCqvwuMw51+1kA+fkmhNw6dV2WKGBsujX3FUeFyZSP7wcMPb0jkt9Cwg== X-Received: by 2002:a7b:caf2:: with SMTP id t18mr14265542wml.35.1590179297323; Fri, 22 May 2020 13:28:17 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id v205sm10350748wmg.11.2020.05.22.13.28.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2020 13:28:16 -0700 (PDT) Subject: Re: [PATCH 1/4] Attribute method inlining To: Hannes Domani , Gdb-patches References: <20200520174032.9525-1-tromey@adacore.com> <20200520174032.9525-2-tromey@adacore.com> <402931801.2106918.1590023319120@mail.yahoo.com> <57ffa2a6-6636-d50c-a058-5244c41e0e96@redhat.com> <1561975515.2543878.1590073437956@mail.yahoo.com> <3b5b38b1-ccf2-199b-d2cd-c17e86659000@redhat.com> <527321070.2641378.1590081500100@mail.yahoo.com> <226240ff-8fa8-e47a-1a3b-0b0f30d41698@redhat.com> From: Pedro Alves Message-ID: <546370c4-2a67-5e29-ee19-0659ff16121b@redhat.com> Date: Fri, 22 May 2020 21:28:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <226240ff-8fa8-e47a-1a3b-0b0f30d41698@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 20:28:29 -0000 On 5/22/20 4:47 PM, Pedro Alves via Gdb-patches wrote: > On 5/21/20 6:18 PM, Hannes Domani via Gdb-patches wrote: >> Am Donnerstag, 21. Mai 2020, 18:42:23 MESZ hat Pedro Alves Folgendes geschrieben: >> >>> On 5/21/20 4:03 PM, Hannes Domani via Gdb-patches wrote: > >>>>> There was a patch for this not that long ago.  Let me try to dig it up. >>>> >>>> You're right, I found it here: >>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158285.html >>> >>> Yes, that's the one! >>> >>>> >>>> So I guess it's not just on Windows that slow. >>>> >>>> And you replied that we maybe should use TOLOWER, ISXDIGIT from libiberty >>>> instead: >>>> https://sourceware.org/pipermail/gdb-patches/2019-June/158518.html >>> >>> This message is actually older than the patch above -- I wrote the patch >>> afterwards. >>> >>> The patch is using the libiberty macros, and avoids the readline clash >>> you run into.  Could you give it a try? >> >> It wasn't immediately obvious to me, but I think you mean this one: >> https://sourceware.org/pipermail/gdb-patches/2019-June/158525.html > > Oh, wow, I confused the "158525" in the url with "158285". They looked > the same number to me. Sorry. Yes, I meant that patch as you found out. > >> >> I tried it, and as expected, I get the same speedup as with my previous >> test, and strcmp_iw_ordered is now in only ~1.5% of the profiling samples. > > Awesome. Let me write some git log / ChangeLog for it and resend it as > a separate thread. Sent here: https://sourceware.org/pipermail/gdb-patches/2020-May/168897.html ( I borrowed Tromey's git log text a bit. :-) ) Thanks, Pedro Alves