From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8853 invoked by alias); 10 Nov 2014 01:39:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8830 invoked by uid 89); 10 Nov 2014 01:39:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pd0-f174.google.com Received: from mail-pd0-f174.google.com (HELO mail-pd0-f174.google.com) (209.85.192.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 10 Nov 2014 01:39:21 +0000 Received: by mail-pd0-f174.google.com with SMTP id p10so6757047pdj.19 for ; Sun, 09 Nov 2014 17:39:20 -0800 (PST) X-Received: by 10.68.88.225 with SMTP id bj1mr28815894pbb.118.1415583559950; Sun, 09 Nov 2014 17:39:19 -0800 (PST) Received: from ShengShiZhuChengdeMacBook-Pro.local ([124.127.118.42]) by mx.google.com with ESMTPSA id uj7sm14978302pac.4.2014.11.09.17.39.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Nov 2014 17:39:18 -0800 (PST) Message-ID: <546018BB.7090601@gmail.com> Date: Mon, 10 Nov 2014 01:39:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Iain Buclaw CC: gdb-patches@sourceware.org, Pedro Alves , Mark Kettenis , gcc-help@gcc.gnu.org Subject: Re: [PATCH v2] gdb/i387-tdep.c: Avoid warning for "-Werror=strict-overflow" References: <5r8dhveikyxjlpoi1mpvti2a.1413156892387@email.android.com> In-Reply-To: <5r8dhveikyxjlpoi1mpvti2a.1413156892387@email.android.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-11/txt/msg00162.txt.bz2 Hello Iain: Is this bug still alive (I joined in bug 63510)? If it is, I shall try to fix it within this month (within 2014-11-30). At present, its status is: - gcc members think that what compiler has done is correct, but need improve its report line number: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63510 - gdb members might think what compiler has done is incorrect (need not report warning). - for me, I agree with gcc members' opinion, and shall try to improve its report line number. Welcome any ideas, suggestions and completions, in time. Thanks. On 10/13/14 7:45, Chen Gang wrote: > Oh, really it is. Originally, I skipped it (do not know it should be as an issue, too). Also sorry for my poor English: misunderstand what you said (this patch can still continue, although gcc 5 has another issue). > > And next, I shall try to fix it, based on what bugzilla has done. But excuse me, I have no enough time resource on it, so maybe can not finish within this month (try to finish within next month) . > > Thanks > > Send from Lenovo A788t. > > > Iain Buclaw wrote: > > On 12 October 2014 15:47, Chen Gang wrote: >> On 10/12/14 22:13, Iain Buclaw wrote: >>> On 12 October 2014 14:28, Chen Gang wrote: >>>> gdb requires "-Werror", and I387_ST0_REGNUM (tdep) is 'variable', then >>>> compiler can think that I387_ST0_REGNUM (tdep) may be a large number, >>>> which may cause issue, so report warning. >>>> >>>> Need fix this warning, and still keep the code clear enough for readers. >>>> The related warning under Darwin with gnu built gcc: >>>> >>> >>> I had noted the same on GCC 5.0.0 development, found that the line >>> number in the warning was wrong and raised a bug >>> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63510), just didn't get >>> round to submitting a patch for gdb. >>> >> >> But for me, what compiler has done is correct: "-Werror=strict-overflow" >> need include "(X + c) >= X" for signed overflow. And our case matches >> this case: >> > > The compiler has done right, but that still doesn't stop the reported > line number being wrong. > > -- Iain. > Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed