From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117311-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12574 invoked by alias); 5 Nov 2014 20:44:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 12565 invoked by uid 89); 5 Nov 2014 20:44:52 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 05 Nov 2014 20:44:51 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sA5KimGS008505	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);	Wed, 5 Nov 2014 15:44:49 -0500
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sA5KikUB016376;	Wed, 5 Nov 2014 15:44:47 -0500
Message-ID: <545A8C3E.5050009@redhat.com>
Date: Wed, 05 Nov 2014 20:44:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/12] btrace: add struct btrace_data
References: <1405346196-1804-1-git-send-email-markus.t.metzger@intel.com> <1405346196-1804-2-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1405346196-1804-2-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-11/txt/msg00103.txt.bz2

Hi Markus,

On 07/14/2014 02:56 PM, Markus Metzger wrote:
> +    default:
> +      gdb_xml_error (parser, _("Btrace format error."));
> +      return;
> +    }

gdb_xml_error throws, so the return is dead.

On 07/14/2014 02:56 PM, Markus Metzger wrote:
> +
> +const char *
> +btrace_format_string (enum btrace_format format)
> +{
> +  switch (format)
> +    {
> +    case BTRACE_FORMAT_NONE: return "No or unknown format";
> +    case BTRACE_FORMAT_BTS: return "Intel(R) Branch Trace Store";

Please put the return statements on their own lines.  Also, I
think at least the first string should go through _() for i18n.

> +    }
> +
> +  internal_error (__FILE__, __LINE__, _("Unknown branch trace format"));
> +}


Thanks,
Pedro Alves