From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-117288-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14085 invoked by alias); 4 Nov 2014 19:17:16 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14058 invoked by uid 89); 4 Nov 2014 19:17:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg21.ericsson.net
Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 04 Nov 2014 19:17:13 +0000
Received: from EUSAAHC008.ericsson.se (Unknown_Domain [147.117.188.96])	by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 56.A9.25146.C7BC8545; Tue,  4 Nov 2014 13:50:04 +0100 (CET)
Received: from [142.133.110.254] (147.117.188.8) by smtps-am.internal.ericsson.com (147.117.188.96) with Microsoft SMTP Server (TLS) id 14.3.174.1; Tue, 4 Nov 2014 14:17:10 -0500
Message-ID: <54592636.8080609@ericsson.com>
Date: Tue, 04 Nov 2014 19:17:00 -0000
From: Simon Marchi <simon.marchi@ericsson.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] tui: Fix newterm call for older ncurses
References: <1415107885-18095-1-git-send-email-simon.marchi@ericsson.com> <5459241C.4000202@redhat.com>
In-Reply-To: <5459241C.4000202@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2014-11/txt/msg00080.txt.bz2

On 2014-11-04 02:08 PM, Pedro Alves wrote:
> On 11/04/2014 01:31 PM, Simon Marchi wrote:
>> Older versions of ncurses' newterm can't take NULL for their ofp and ifp
>> parameters. Newer versions can, and they fall back on stdout/stdin if
>> that is the case.
>>
>> This patch explicitely passes stdout/stdin to the call to newterm to
> 
> "explicitly"
> 
>> avoid segfaulting with older ncurses.
>>
>> Reference: https://sourceware.org/ml/gdb-patches/2014-11/msg00055.html
>>
> 
> OK.
> 
>> gdb/Changelog:
>>
>> 2014-11-04  Simon Marchi  <simon.marchi@ericsson.com>
>>
>> 	* tui/tui.c (tui_enable): Pass pass stdout and stdin to newterm.
> 
> Double "pass".
> 
> Thanks,
> Pedro Alves

Pushed with the fixes to the commit message and ChangeLog, thanks.