From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12280 invoked by alias); 30 Oct 2014 22:26:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12269 invoked by uid 89); 30 Oct 2014 22:26:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: elasmtp-mealy.atl.sa.earthlink.net Received: from elasmtp-mealy.atl.sa.earthlink.net (HELO elasmtp-mealy.atl.sa.earthlink.net) (209.86.89.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Oct 2014 22:26:52 +0000 Received: from [68.104.56.205] (helo=macbook2.local) by elasmtp-mealy.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1XjyB8-0006Ro-Bh for gdb-patches@sourceware.org; Thu, 30 Oct 2014 18:26:50 -0400 Message-ID: <5452BB29.8090803@earthlink.net> Date: Thu, 30 Oct 2014 22:26:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: GCC switch to C11 causes many testsuite compiler diagnostics References: <544BD7E6.1050602@codesourcery.com> <874mula6db.fsf@br87z6lw.de.ibm.com> In-Reply-To: <874mula6db.fsf@br87z6lw.de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940897f78249a17c1aa19640b37b2870158350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00853.txt.bz2 On 10/30/14, 9:07 AM, Andreas Arnez wrote: > On Sat, Oct 25 2014, Sandra Loosemore wrote: > >> Comparing my latest nios2 test results (with Pedro's thread patch) >> with those from a checkout a couple weeks old, I noticed I had some >> new ERRORs due to apparent compilation failures. I tracked this down >> to the recent change on GCC mainline (r216247) to make the default C >> dialect GNU11, which enables -Wimplicit-int and >> -Wimplicit-function-declaration by default. I started working on a >> patch to fix the offending testcases, but realized that there are >> hundreds of them. :-( > > The warnings appear in our S390 testing as well, so I've been working on > a fix already, as announced here: > > https://sourceware.org/ml/gdb-testers/2014-q4/msg00037.html > > In the meantime I've completed a patch set; maybe you'd like to check > that it does fix the warnings on NIOS2: > > https://sourceware.org/ml/gdb-patches/2014-10/msg00802.html > >> >> So, before I invest a lot more time on this, is updating the GDB >> testsuite to use a more modern C dialect the Right Thing To Do? I'm >> also wondering if it's really necessary to support compilers that >> can't handle function prototypes in the testsuite (not defining >> PROTOTYPES seems to be the default, in fact). > > AFAIK there's no need to support pre-C89 compilers that can't handle > function prototypes. GDB itself can't be compiled with such a compiler, > and many GDB test cases wouldn't work either. > > -- > Andreas I looked at your patch, but haven't replied because I'm still waffling about it. In theory, GDB could be handed an executable that was built in 1988 and most debugging actions would work. In practice, the old executable is unlikely to run on any modern hardware, and we've already decided not to expend much effort to support old hardware. Where things are a little murkier is K&R-style source code. There was a lot out there at one time, but most (all?) maintained sources have been converted sometime in the intervening quarter-century. Perhaps the thing to do is pose this as a trivia quiz - what K&R sources are still being built and debugged on today's systems? Stan stan@codesourcery.com