From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28946 invoked by alias); 28 Oct 2014 13:01:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28922 invoked by uid 89); 28 Oct 2014 13:01:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Oct 2014 13:01:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9SD1WVx015633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 28 Oct 2014 09:01:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9SD1U6K019471; Tue, 28 Oct 2014 09:01:31 -0400 Message-ID: <544F93A9.5000701@redhat.com> Date: Tue, 28 Oct 2014 13:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 12/13 v2] Move low-level Linux x86 debug register code to a shared file References: <1412848358-9958-1-git-send-email-gbenson@redhat.com> <1412848358-9958-13-git-send-email-gbenson@redhat.com> In-Reply-To: <1412848358-9958-13-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00764.txt.bz2 On 10/09/2014 10:52 AM, Gary Benson wrote: > diff --git a/gdb/nat/x86-linux-dregs.c b/gdb/nat/x86-linux-dregs.c > new file mode 100644 > index 0000000..3e3d876 > --- /dev/null > +++ b/gdb/nat/x86-linux-dregs.c > @@ -0,0 +1,173 @@ > +/* Low-level debug register code for x86 (i386 and x86-64). I think this comment should mention "Linux" too. > +++ b/gdb/nat/x86-linux-dregs.h > @@ -0,0 +1,53 @@ > +/* Low-level debug register code for x86 (i386 and x86-64). Likewise. Otherwise OK. Thanks, Pedro Alves