From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26284 invoked by alias); 28 Oct 2014 13:00:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26243 invoked by uid 89); 28 Oct 2014 13:00:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Oct 2014 13:00:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9SCxw8f027265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 28 Oct 2014 08:59:59 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9SCxuu1011323; Tue, 28 Oct 2014 08:59:57 -0400 Message-ID: <544F934C.5000509@redhat.com> Date: Tue, 28 Oct 2014 13:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 11/13 v2] Introduce x86_linux_update_debug_registers References: <1412848358-9958-1-git-send-email-gbenson@redhat.com> <1412848358-9958-12-git-send-email-gbenson@redhat.com> In-Reply-To: <1412848358-9958-12-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00763.txt.bz2 On 10/09/2014 10:52 AM, Gary Benson wrote: > This commit moves the entire body of both GDB's and gdbserver's > x86_linux_prepare_to_resume functions into new functions, > x86_linux_update_debug_registers. This reorganisation allows > all Linux x86 low-level debug register code to be placed in one > shared file, separate from general Linux x86 shared code. > > gdb/ChangeLog: > > * x86-linux-nat.c (x86_linux_update_debug_registers): > New function. > (x86_linux_prepare_to_resume): Call the above. I'd prefer making it a little clearer that this is code being factored out, instead of being really new code, like: * x86-linux-nat.c (x86_linux_update_debug_registers): New function, factored out from ... (x86_linux_prepare_to_resume): ... this. > gdb/gdbserver/ChangeLog: > > * linux-x86-low.c (x86_linux_update_debug_registers): > New function. > (x86_linux_prepare_to_resume): Call the above. OK. Thanks, Pedro Alves