From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19632 invoked by alias); 28 Oct 2014 12:57:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19620 invoked by uid 89); 28 Oct 2014 12:57:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Oct 2014 12:57:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9SCvbac014199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 28 Oct 2014 08:57:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9SCvZdI016143; Tue, 28 Oct 2014 08:57:36 -0400 Message-ID: <544F92BF.3050602@redhat.com> Date: Tue, 28 Oct 2014 12:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH 07/13 v2] Make lwp_info.arch_private handling shared References: <1412848358-9958-1-git-send-email-gbenson@redhat.com> <1412848358-9958-8-git-send-email-gbenson@redhat.com> In-Reply-To: <1412848358-9958-8-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00759.txt.bz2 On 10/09/2014 10:52 AM, Gary Benson wrote: > This commit moves the code to handle lwp_info.arch_private for > Linux x86 into a new shared file, nat/x86-linux.c. > > gdb/ChangeLog: > > * nat/x86-linux.h: New file. > * nat/x86-linux.c: Likewise. > * Makefile.in (HFILES_NO_SRCDIR): Add nat/x86-linux.h. > (x86-linux.o): New rule. > * config/i386/linux.mh (NATDEPFILES): Add x86-linux.o. > * config/i386/linux64.mh (NATDEPFILES): Likewise. > * nat/linux-nat.h (struct arch_lwp_info): New forward declaration. > (lwp_set_arch_private_info): New declaration. > (lwp_arch_private_info): Likewise. > * linux-nat.c (lwp_set_arch_private_info): New function. > (lwp_arch_private_info): Likewise. > * x86-linux-nat.c: Include nat/x86-linux.h. > (arch_lwp_info): Removed structure. > (update_debug_registers_callback): > Use lwp_set_debug_registers_changed. > (x86_linux_prepare_to_resume): Use lwp_debug_registers_changed > and lwp_set_debug_registers_changed. > (x86_linux_new_thread): Use lwp_set_debug_registers_changed. > > gdb/gdbserver/ChangeLog: > > * Makefile.in (x86-linux.o): New rule. > * configure.srv: Add x86-linux.o to relevant targets. > * linux-low.c (lwp_set_arch_private_info): New function. > (lwp_arch_private_info): Likewise. > * linux-x86-low.c: Include nat/x86-linux.h. > (arch_lwp_info): Removed structure. > (update_debug_registers_callback): > Use lwp_set_debug_registers_changed. > (x86_linux_prepare_to_resume): Use lwp_debug_registers_changed > and lwp_set_debug_registers_changed. > (x86_linux_new_thread): Use lwp_set_debug_registers_changed. OK. Thanks, Pedro Alves