Re: [PATCH] stepi/nexti: skip signal handler if "handle nostop" signal arrives

Eli Zaretskii
2014-10-15T14:31:04Z

> Date: Wed, 15 Oct 2014 14:40:49 +0100
> From: Pedro Alves <palves@redhat.com>
> CC: gdb-patches@sourceware.org
>
> On 10/14/2014 08:22 PM, Eli Zaretskii wrote:
> >> Date: Tue, 14 Oct 2014 19:49:40 +0100
> >> From: Pedro Alves <palves@redhat.com>
>
> > I think this text mixes 2 different things: (1) how the signal
> > handling affects whether the signal gets to the program or not, and is
> > it announced or not; and (2) the fine details of when the signal
> > becomes "known" to the program and how stepping commands affect and
> > are affected by that.
> >
> > It might be the simplest to separate the two issues, and describe each
> > one on its own.
>
> I'll give that a try.

Thanks. Let me know if I can help.

> >> No, we intercept the signal before the program sees it. See above.
> >
> > But you wrote "the program stops for a signal". "The program stops"
> > means (or at least could be interpreted as meaning) the signal was
> > already seen by the program, and the program then stopped.
> >
> > See how this is confusing?
>
> I don't see how one would be confused, as the paragraph just above
> says "When a signal stops your program", and I feel that the that
> wording I chose follows naturally from that.

As long as we didn't try to talk about fine details that happen at
that time, it was okay.

> I'll come up with a new version once I have a chance.

Thanks in advance.