From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16855 invoked by alias); 24 Oct 2014 22:07:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16839 invoked by uid 89); 24 Oct 2014 22:07:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 24 Oct 2014 22:07:06 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9OM714O009970 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Oct 2014 18:07:01 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9OM6xJo030974; Fri, 24 Oct 2014 18:07:00 -0400 Message-ID: <544ACD83.2050509@redhat.com> Date: Fri, 24 Oct 2014 22:07:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Doug Evans CC: Sandra Loosemore , gdb-patches@sourceware.org Subject: Re: Cannot execute this command without a live selected thread. References: <544A7648.6060102@codesourcery.com> <544A7930.4040909@redhat.com> <544A8741.9090705@codesourcery.com> <544A8B0C.5000509@redhat.com> <544A8F15.9000906@redhat.com> <21578.42546.658345.633154@ruffy.mtv.corp.google.com> <544AAB39.4030503@redhat.com> <21578.45122.246973.309386@ruffy.mtv.corp.google.com> <544AB48A.9080503@redhat.com> <21578.47311.671976.969985@ruffy.mtv.corp.google.com> In-Reply-To: <21578.47311.671976.969985@ruffy.mtv.corp.google.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00679.txt.bz2 On 10/24/2014 09:38 PM, Doug Evans wrote: > Pedro Alves writes: > > > Not all targets use ptid.lwp. > > > > All process_stratum targets do. > > windows-nat.c doesn't > (at least I remember seeing all calls to ptid_build there > passing 0 for lwp). > Could be missing something of course. Eh, I was quite sure I once wrote a patch for that, and I thought I had pushed it, but I can't find it now. Ah, back in 2008 I went through all targets migrating away from storing the thread in ptid_t.pid. commit 2dc38344f418c9abe65755308ef6db836a61103a Author: Pedro Alves Use ptid_t.tid to store thread ids instead of ptid_t.pid. * win32-nat.c (win32_add_thread): Change thread argument type to etc. That made way for the multi-process support in the core being able to rely on ptid_t.pid. It was much later (years) that I realized that ptid.lwpid would be a better field. Anyway, should be a trivial change. Nothing outside the target should be looking at ptid.lwpid vs ptid.tid. I fixed gnu-nat.c and remote.c recently, but I now see that nto-procfs.c, remote-sim.c and darwin-nat.c still haven't been given the treatment. I got confused with wishful thinking. :-P > > > I believe that on the GDB side too, it's best that we standardize on > > process_stratum targets using the ptid.lwp field to store thread ids > > anyway. The idea being leave the ptid.tid field free for any > > thread_stratum target that might want to sit on top. > > The language in the comment in ptid.h waffles a bit: > > process_stratum targets that handle threading themselves should > prefer using the ptid.lwp field, leaving the ptid.tid field for any > thread_stratum target that might want to sit on top. > > Can we make this more of a rule than just a "should prefer"? > [and fix targets to follow] Sure, guess I didn't use a stronger word at the time because I hadn't yet forgotten that the all-targets conversion wasn't finished. :-) Thanks, Pedro Alves