From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24368 invoked by alias); 22 Oct 2014 21:59:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24358 invoked by uid 89); 22 Oct 2014 21:59:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Oct 2014 21:59:27 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9MLxPf0031372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Oct 2014 17:59:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9MLxNmd029348; Wed, 22 Oct 2014 17:59:24 -0400 Message-ID: <544828BB.9040900@redhat.com> Date: Wed, 22 Oct 2014 21:59:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Martin Galvan , gdb-patches@sourceware.org Subject: Re: [PATCH] Python API: Add gdb.is_in_prologue and gdb.is_in_epilogue. References: <1413986485-4673-1-git-send-email-martin.galvan@tallertechnologies.com> <544822D6.8020606@redhat.com> In-Reply-To: <544822D6.8020606@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00592.txt.bz2 On 10/22/2014 10:34 PM, Pedro Alves wrote: >> +# Get the current frame object. >> > +gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \ >> > + "Get the current frame object." 0 > Lowercase, and no "." please. Here and throughout. Usual style is to > drop the "the"s to be more concise: > > gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \ ^^^^^^^^ > "get current frame object" 0 ^^^^^^^ BTW, I happened to read this back, and noticed: "current" and "selected" have distinct meanings in the frame machinery. Best not mix them up: gdb_py_test_silent_cmd "python selectedFrame = gdb.selected_frame()" \ "get selected frame object" 0 Thanks, Pedro Alves