On 10/21/2014 11:03 AM, Yao Qi wrote: > Luis Machado writes: > >> + /* Handle bit P. */ >> + if (bit (arm_insn_r->arm_insn, 24)) >> + { >> + record_buf_mem[1] = tgt_mem_addr; >> + } >> + else >> + { >> + record_buf_mem[1] = (uint32_t) u_regval; >> + } > > These braces are not necessary. > Thanks. Comments addressed in the attached updated patch. I added another check for wback so we only save the base register when needed. I plan to commit this version in a couple days unless there are objections. Luis