From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16480 invoked by alias); 21 Oct 2014 12:16:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16467 invoked by uid 89); 21 Oct 2014 12:16:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Oct 2014 12:16:20 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XgYML-0004A2-P9 from Luis_Gustavo@mentor.com for gdb-patches@sourceware.org; Tue, 21 Oct 2014 05:16:17 -0700 Received: from [172.30.14.191] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.181.6; Tue, 21 Oct 2014 05:16:17 -0700 Message-ID: <54464E8D.8030503@codesourcery.com> Date: Tue, 21 Oct 2014 12:16:00 -0000 From: Luis Machado Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: "'gdb-patches@sourceware.org'" , Yao Qi Subject: Re: [PATCH, v2] Fix ARM machine state testcase failures References: <54464B82.6030703@codesourcery.com> In-Reply-To: <54464B82.6030703@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00545.txt.bz2 On 10/21/2014 10:03 AM, Luis Machado wrote: > - if (bit (arm_insn_r->arm_insn, 20) && !bit (arm_insn_r->arm_insn, 22)) > - { > - register_bits = bits (arm_insn_r->arm_insn, 0, 15); > - no_of_regs = 15; > - } > - else > - { > - register_bits = bits (arm_insn_r->arm_insn, 0, 14); > - no_of_regs = 14; > - } Forgot to mention. I saw this bit of code but did not find signs of these patterns in the documentation i have access to. I suppose it may be some older encoding of the instructions (26-bit)? The comments don't really make it clear enough. If someone knows more about this distinction, please do share the details. Luis