From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15677 invoked by alias); 17 Oct 2014 22:29:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15659 invoked by uid 89); 17 Oct 2014 22:29:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Oct 2014 22:29:51 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XfG1r-0002Ej-HK from Kwok_Yeung@mentor.com ; Fri, 17 Oct 2014 15:29:47 -0700 Received: from [192.168.1.49] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Fri, 17 Oct 2014 23:29:46 +0100 Message-ID: <54419857.4070504@codesourcery.com> Date: Fri, 17 Oct 2014 22:29:00 -0000 From: Kwok Cheung Yeung User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Fix gdb.dwarf2/dw2-dir-file-name.exp test for MIPS architectures References: <54399A91.8000006@mentor.com> <5441066B.7000402@redhat.com> In-Reply-To: <5441066B.7000402@redhat.com> Content-Type: text/plain; charset="shift_jis" Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00496.txt.bz2 Maciej has already reviewed this patch internally, and I can confirm that the test still passes cleanly on x86_64 Linux. If there are no objections I will go ahead and commit it tomorrow. Thanks, Kwok On 17/10/2014 1:07 PM, Pedro Alves wrote: > Looks fine to me, but I'd like to hear Maciej's OK on the MIPS specifics too. > > Please make sure x86_64 still works. > > I wonder if this test could be simplified using the testsuite's dwarf > assembler (Dwarf::assemble). > >> >> Kwok >> >> 2014-08-14 Kwok Cheung Yeung >> >> gdb/testsuite/ >> * gdb.dwarf2/dw2-dir-file-name.exp (addr_len): New. >> (out_cu): Use addr_len for the size of addresses. >> (out_line): Likewise. Size DW_LNE_set_address instruction >> according to addr_len. >> * gdb.dwarf2/dw2-dir-file-name.c (START_INSNS): New. >> (FUNC): Add START_INSNS to definition. >> > > > Thanks, > Pedro Alves >