[patch] signal_command: Leftover cleanup chain regression [Re: [PATCH 4/4] PR gdb/17471: Repeating a background command makes it foreground]

Jan Kratochvil
2015-08-04T08:28:57Z

[-- Attachment #1: Type: text/plain, Size: 44 bytes --]

Hi,

mostly harmless but not correct.

Jan

[-- Attachment #2: 1 --]
[-- Type: text/plain, Size: 604 bytes --]

gdb/ChangeLog
2015-08-04 Jan Kratochvil <jan.kratochvil@redhat.com>

* infcmd.c (signal_command): Call do_cleanups for args_chain.

diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 4948d27..e4b2045 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -1264,6 +1264,8 @@ signal_command (char *signum_exp, int from_tty)
oursig = gdb_signal_from_command (num);
}

+ do_cleanups (args_chain);
+
/* Look for threads other than the current that this command ends up
resuming too (due to schedlock off), and warn if they'll get a
signal delivered. "signal 0" is used to suppress a previous