From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26154 invoked by alias); 17 Oct 2014 12:42:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26144 invoked by uid 89); 17 Oct 2014 12:42:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Oct 2014 12:42:50 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9HCglNt006194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Oct 2014 08:42:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9HCgk7F021450; Fri, 17 Oct 2014 08:42:46 -0400 Message-ID: <54410EC5.7000808@redhat.com> Date: Fri, 17 Oct 2014 12:42:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Jose E. Marchesi" CC: gdb-patches@sourceware.org Subject: Re: [PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-7-git-send-email-jose.marchesi@oracle.com> <544041A7.50802@gmail.com> <874mv2yime.fsf@oracle.com> In-Reply-To: <874mv2yime.fsf@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00470.txt.bz2 On 10/17/2014 01:40 PM, Jose E. Marchesi wrote: > > Hi Pedro. > > Thanks for your suggestions. I updated the patch addressing them. > Thanks, looks good. I'm left wondering about the Solaris question though. :-) Just a minor detail I missed first time around: > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -28,6 +28,8 @@ > #include "gdbtypes.h" > #include "reggroups.h" > #include "regset.h" > +#include "parser-defs.h" > +#include "user-regs.h" Please also mention these include in the CL, like: * amd64-linux-tdep.c: Include "parser-defs.h" and "user-regs.h". (amd64_dtrace_parse_probe_argument): New function. ... Thanks, Pedro Alves