From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29071 invoked by alias); 17 Oct 2014 12:18:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28998 invoked by uid 89); 17 Oct 2014 12:18:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Oct 2014 12:18:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9HCHwJ2002247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Oct 2014 08:17:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9HCHuNE030975; Fri, 17 Oct 2014 08:17:57 -0400 Message-ID: <544108F4.6020606@redhat.com> Date: Fri, 17 Oct 2014 12:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Jose E. Marchesi" CC: gdb-patches@sourceware.org Subject: Re: [PATCH V2 7/9] Simple testsuite for DTrace USDT probes. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-8-git-send-email-jose.marchesi@oracle.com> <54404878.50406@redhat.com> <87bnpa3nwm.fsf@oracle.com> In-Reply-To: <87bnpa3nwm.fsf@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00468.txt.bz2 Hi Jose, On 10/17/2014 01:02 PM, Jose E. Marchesi wrote: > Thanks for your suggestions. Please take a look to this new version of > the patch. I think it addresses all your concerns :) Indeed it does. Thanks much. One tiny nit: > + if {[dtrace_build_usdt_test_program] == -1} { > + untested ${testfile}.exp > + return -1 > + } Something odd with indentation there. "untested ${testfile}.exp" is an anti-idiom in lots of tests :-) See https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#A.22untested.22_calls . Write instead: untested "could not compile test program" Otherwise looks good. Thanks, Pedro Alves