From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5681 invoked by alias); 17 Oct 2014 11:15:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5645 invoked by uid 89); 17 Oct 2014 11:15:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Oct 2014 11:15:16 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9HBFDJU011463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Oct 2014 07:15:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9HBFBfD029931; Fri, 17 Oct 2014 07:15:12 -0400 Message-ID: <5440FA3F.4000805@redhat.com> Date: Fri, 17 Oct 2014 11:15:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Skip argv0-symlink.exp on target argv[0] isn't available References: <1413440712-3645-1-git-send-email-yao@codesourcery.com> <54400505.6070908@redhat.com> <87lhofkvr8.fsf@codesourcery.com> In-Reply-To: <87lhofkvr8.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00463.txt.bz2 On 10/17/2014 08:20 AM, Yao Qi wrote: >>> >> + >>> >> + send_gdb "p argv\[0\]\n" >>> >> + gdb_expect { >>> >> + -re " = $hex \".*$exe\"\r\n${gdb_prompt} $" { >> > >> > I suspect this may break if remote (host|target) testing, >> > and not sharing the filesystem between build/host/target. >> > Isn't $exe here a full path on the build? >> > > $exe can be a full path, and can be a base name too. It depends on proc > standard_temp_file. You are right that it is a mistake to use the build > file path on host. I change it to > > ".*[file tail $exe]\"\r\n${gdb_prompt} $" OK. So I'm somewhat worried about silently reducing coverage due to some problem here, either now, or in the future. So how about instead of silently skipping the tests, call unsupported, like: global has_argv0 set test "verify dereferenced value" if { $has_argv0 } { gdb_test "python print (arg0)" "0x.*$testfile\"" $test } else { unsupported $test } etc. > +gdb_caching_proc gdb_has_argv0 { > + set result 0 ... > + # Helper proc. > + proc gdb_has_argv0_1 { exe } { ... > + set result [gdb_has_argv0_1 $exe] And then in addition, add an assert here for the main OSs we support, like so: if { !$result && ([istarget *-*-linux*] || [istarget *-*-gnu*] || [istarget *-*-cygwin*] || [istarget *-*-mingw*] || [istarget *-*-darwin*] || [istarget *-*-bsd*] || [istarget *-*-solaris*] || [istarget *-*-msdosdjgpp*] || [istarget *-*-go32*] || [istarget *-*-aix*] || [istarget *-*-hpux*]) } { fail "argv[0] should be available on this target" } > + # Helper proc. > + proc gdb_has_argv0_1 { exe } { > + global srcdir subdir > + global gdb_prompt hex decimal > + > + gdb_exit > + gdb_start > + gdb_reinitialize_dir $srcdir/$subdir > + gdb_load "$exe" BTW, use clean_restart here? (if so, I think 'global srcdir subdir' becomes unnecessary too)