From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4718 invoked by alias); 16 Oct 2014 22:17:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4699 invoked by uid 89); 16 Oct 2014 22:17:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,LIKELY_SPAM_BODY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 16 Oct 2014 22:17:25 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9GMHM76017520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Oct 2014 18:17:22 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9GMHKLM029126; Thu, 16 Oct 2014 18:17:21 -0400 Message-ID: <544043F0.70001@redhat.com> Date: Thu, 16 Oct 2014 22:17:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: "Jose E. Marchesi" , gdb-patches@sourceware.org Subject: Re: [PATCH V2 6/9] Support for DTrace USDT probes in x86_64 targets. References: <1412961772-16249-1-git-send-email-jose.marchesi@oracle.com> <1412961772-16249-7-git-send-email-jose.marchesi@oracle.com> In-Reply-To: <1412961772-16249-7-git-send-email-jose.marchesi@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00444.txt.bz2 I forgot: On 10/10/2014 06:22 PM, Jose E. Marchesi wrote: > 2014-10-10 Jose E. Marchesi > > * amd64-linux-tdep.h: Prototypes for > `amd64_dtrace_parse_probe_argument', `amd64_dtrace_enable_probe', > `amd64_dtrace_disable_probe' and > `gdbarch_dtrace_probe_is_enabled'. Typo: gdbarch_dtrace_probe_is_enabled: gdbarch => amd64_dtrace. Write it like this: * amd64-linux-tdep.h (amd64_dtrace_parse_probe_argument) (amd64_dtrace_enable_probe, amd64_dtrace_disable_probe) (amd64_dtrace_probe_is_enabled): New declarations. But, I don't see why these functions are extern, they're defined and used in the same file. So make them static and don't touch amd64-linux-tdep.h. OTOH, does DTrace on Solaris use this exact same sequences? If so, then better put these new functions somewhere non-Linux-specific instead, like e.g., amd64-tdep.c. > * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): New function. > (amd64_dtrace_probe_is_enabled): Likewise. > (amd64_dtrace_enable_probe): Likewise. > (amd64_dtrace_disable_probe): Likewise. > (amd64_linux_init_abi): Register the > `gdbarch_dtrace_probe_argument', `gdbarch_dtrace_enable_probe', > `gdbarch_dtrace_disable_probe' and `gdbarch_dtrace_probe_is_enabled'. Register the ... _hooks_? Thanks, Pedro Alves