From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7581 invoked by alias); 16 Oct 2014 18:18:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7472 invoked by uid 89); 16 Oct 2014 18:18:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 16 Oct 2014 18:18:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9GIIQkG008834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 16 Oct 2014 14:18:26 -0400 Received: from localhost.localdomain (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9GIIOPk022791; Thu, 16 Oct 2014 14:18:25 -0400 Message-ID: <54400BF0.9010501@redhat.com> Date: Thu, 16 Oct 2014 18:18:00 -0000 From: Phil Muldoon MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Small fixes to the Python API doc References: <1413482796-3090-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1413482796-3090-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00435.txt.bz2 On 16/10/14 19:06, Simon Marchi wrote: > First: > "Breakpoint.delete" is missing parenthesis. > > Second: > Someone on IRC asked, how come there is no disable() method in the > Breakpoint object. It turns out you have to do "bp.enabled = False". > Since every normal person would probably search for "disable" in that page > if their intent is to disable a python breakpoint, I thought it would be > useful if the description contained "disable" so it would be easy to find. > The result might seem a bit silly and redundant, so I am open to > suggestions. > > gdb/doc/ChangeLog: > > * python.texi (Breakpoints In Python): Add parenthesis after > Breakpoint.delete. Clarify Breakpoint.enabled description so > that it contains "disable". > --- > gdb/doc/python.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > > @defvar Breakpoint.enabled > This attribute is @code{True} if the breakpoint is enabled, and > -@code{False} otherwise. This attribute is writable. > +@code{False} otherwise. You can use it to enable or disable the breakpoint. > +This attribute is writable. > @end defvar > > @defvar Breakpoint.silent No objections to the patch, but maybe we should "just have" a disable() method even if it duplicates the functionality of the enabled attribute. What do you think? Cheers Phil