From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13215 invoked by alias); 16 Oct 2014 07:38:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13202 invoked by uid 89); 16 Oct 2014 07:38:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f49.google.com Received: from mail-pa0-f49.google.com (HELO mail-pa0-f49.google.com) (209.85.220.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 16 Oct 2014 07:38:16 +0000 Received: by mail-pa0-f49.google.com with SMTP id hz1so2887792pad.8 for ; Thu, 16 Oct 2014 00:38:15 -0700 (PDT) X-Received: by 10.66.221.3 with SMTP id qa3mr17803893pac.63.1413445094971; Thu, 16 Oct 2014 00:38:14 -0700 (PDT) Received: from ShengShiZhuChengdeMacBook-Pro.local ([124.126.239.21]) by mx.google.com with ESMTPSA id al4sm17081664pbc.19.2014.10.16.00.38.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Oct 2014 00:38:13 -0700 (PDT) Message-ID: <543F7745.3060400@gmail.com> Date: Thu, 16 Oct 2014 07:38:00 -0000 From: Chen Gang User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andreas Schwab CC: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/hppa-tdep.c: Fix a logical typo bug found by compiler warning References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00418.txt.bz2 On 10/16/14 15:06, Andreas Schwab wrote: > There's another bug in this function: > > /* Does it look like a stw? */ > if ((inst >> 26) == 0x1a || (inst >> 26) == 0x1b > || (inst >> 26) == 0x1f > || ((inst >> 26) == 0x1f > && ((inst >> 6) == 0xa))) > return hppa_extract_5R_store (inst); > > The last condition is redundant. > OK, thanks. For me, it is another typo issue bug, according to the code within inst_saves_gr(), need use "(inst >> 26) == 0x03" instead of the 2nd "(inst >> 26) == 0x1f". And are any members familiar with the related logical working flow? If no reply within this week end, I shall try to be familiar with the related working flow firstly, then make patch v2 within this month. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed