Re: [PATCH v2] gdb/i387-tdep.c: Avoid warning for "-Werror=strict-overflow"

Mark Kettenis
2014-10-15T18:59:12Z

> Date: Wed, 15 Oct 2014 11:47:11 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hi Mark,
>
> > > Sorry, I disagree with this approach. I think your compiler is really
> > > being unhelpful here. See if a newer GCC version of the compiler
> > > still triggers that warning. If so, complain to the GCC people.
>
> Would you be OK with Pedro's suggested approach where we have
> an additional macro that provides the number of ST registers?
> That should get rid of the warning, and it seems like the code
> might actually even be slightly better for it; it would make it
> obvious that you iterate over a fixed number of registers, and
> which ones you are interating over; [ST0 .. XMM0[ does not make
> it as clear that the range only refers to ST registers, for instance.

Pedro's suggestion made sense to me.