Re: [PATCH] gdb/hppa-tdep.c: Fix a logical typo bug found by compiler warning

Chen Gang
2014-10-16T07:38:18Z

On 10/16/14 15:06, Andreas Schwab wrote:
> There's another bug in this function:
>
> /* Does it look like a stw? */
> if ((inst >> 26) == 0x1a || (inst >> 26) == 0x1b
> || (inst >> 26) == 0x1f
> || ((inst >> 26) == 0x1f
> && ((inst >> 6) == 0xa)))
> return hppa_extract_5R_store (inst);
>
> The last condition is redundant.
>

OK, thanks.

For me, it is another typo issue bug, according to the code within
inst_saves_gr(), need use "(inst >> 26) == 0x03" instead of the 2nd
"(inst >> 26) == 0x1f".

And are any members familiar with the related logical working flow? If
no reply within this week end, I shall try to be familiar with the
related working flow firstly, then make patch v2 within this month.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed