Re: [PATCH] gdb/hppa-tdep.c: Fix a logical typo bug found by compiler warning

Andreas Schwab
2014-10-16T07:06:51Z

There's another bug in this function:

/* Does it look like a stw? */
if ((inst >> 26) == 0x1a || (inst >> 26) == 0x1b
|| (inst >> 26) == 0x1f
|| ((inst >> 26) == 0x1f
&& ((inst >> 6) == 0xa)))
return hppa_extract_5R_store (inst);

The last condition is redundant.

Andreas.

--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."