From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6582 invoked by alias); 11 Oct 2014 21:01:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6569 invoked by uid 89); 11 Oct 2014 21:01:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Oct 2014 21:01:12 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Xd3mm-0003lq-Mb from Kwok_Yeung@mentor.com for gdb-patches@sourceware.org; Sat, 11 Oct 2014 14:01:09 -0700 Received: from [192.168.1.49] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Sat, 11 Oct 2014 22:01:07 +0100 Message-ID: <54399A91.8000006@mentor.com> Date: Sat, 11 Oct 2014 21:01:00 -0000 From: Kwok Cheung Yeung User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Subject: [PATCH] Fix gdb.dwarf2/dw2-dir-file-name.exp test for MIPS architectures Content-Type: multipart/mixed; boundary="------------020206000105000209030406" X-SW-Source: 2014-10/txt/msg00294.txt.bz2 --------------020206000105000209030406 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1413 This patch fixes the failures that occur with the gdb.dwarf2/dw2-dir-file-name.exp test on 64-bit MIPS and compressed MIPS ISAs (i.e. MIPS16 and microMIPS). The failures on 64-bit occur because the generated DWARF address information is always 32-bit, which causes the upper 32-bits of addresses to be truncated and causes breakpoints to be set on the wrong address if any of the upper 32-bits are non-zero. I suspect that other 64-bit architectures get away with it because they place all their instructions at a VMA lower than 2^32 by default. This patch causes 64-bit addresses to be generated if a 64-bit target is detected. The failures on MIPS16 and microMIPS occur because the breakpoint address needs to have the LSB set to 1 (used to indicate that the code is compressed). However, the function name is interpreted as a data label, causing GDB to set breakpoints at even addresses. This is fixed by explicitly adding a '.insn' directive (see https://sourceware.org/binutils/docs/as/MIPS-insn.html) after the label on MIPS only. Kwok 2014-08-14 Kwok Cheung Yeung gdb/testsuite/ * gdb.dwarf2/dw2-dir-file-name.exp (addr_len): New. (out_cu): Use addr_len for the size of addresses. (out_line): Likewise. Size DW_LNE_set_address instruction according to addr_len. * gdb.dwarf2/dw2-dir-file-name.c (START_INSNS): New. (FUNC): Add START_INSNS to definition. --------------020206000105000209030406 Content-Type: text/plain; charset="Shift_JIS"; name="gdb_dw2-dir-file-name.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="gdb_dw2-dir-file-name.patch" Content-length: 5283 ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmR3YXJmMi9kdzItZGly LWZpbGUtbmFtZS5jIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL2R3Mi1k aXItZmlsZS1uYW1lLmMKaW5kZXggNTE3ZGY5MC4uNjlhYWQzMCAxMDA2NDQK LS0tIGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL2R3Mi1kaXItZmlsZS1u YW1lLmMKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuZHdhcmYyL2R3Mi1kaXIt ZmlsZS1uYW1lLmMKQEAgLTYzLDYgKzYzLDEyIEBAIEZVTkMgKGNvbXBkaXJf YWJzb2x1dGVfbGRpcl9hYnNvbHV0ZV9maWxlX3JlbGF0aXZlX2RpZmZlcmVu dCkJXAogRlVOQyAoY29tcGRpcl9hYnNvbHV0ZV9sZGlyX2Fic29sdXRlX2Zp bGVfYWJzb2x1dGVfc2FtZSkJXAogRlVOQyAoY29tcGRpcl9hYnNvbHV0ZV9s ZGlyX2Fic29sdXRlX2ZpbGVfYWJzb2x1dGVfZGlmZmVyZW50KQogCisjaWZk ZWYgX19taXBzX18KKyNkZWZpbmUgU1RBUlRfSU5TTlMgYXNtICgiLmluc25c biIpOworI2Vsc2UKKyNkZWZpbmUgU1RBUlRfSU5TTlMKKyNlbmRpZgorCiAv KiBOb3RlczogKDEpIFRoZSAnKl9zdGFydCcgbGFiZWwgYmVsb3cgaXMgbmVl ZGVkIGJlY2F1c2UgJ25hbWUnIG1heQogICAgcG9pbnQgdG8gYSBmdW5jdGlv biBkZXNjcmlwdG9yIGluc3RlYWQgb2YgdG8gdGhlIGFjdHVhbCBjb2RlLiAg KDIpCiAgICBUaGUgJy5iYWxpZ24nIHNob3VsZCBzcGVjaWZ5IHRoZSBoaWdo ZXN0IHBvc3NpYmxlIGZ1bmN0aW9uCkBAIC03Miw2ICs3OCw3IEBAIEZVTkMg KGNvbXBkaXJfYWJzb2x1dGVfbGRpcl9hYnNvbHV0ZV9maWxlX2Fic29sdXRl X2RpZmZlcmVudCkKICNkZWZpbmUgRlVOQyhuYW1lKQkJCQkJXAogICBhc20g KCIuYmFsaWduIDgiKTsJCQkJCVwKICAgYXNtICgjbmFtZSAiX3N0YXJ0OiAu Z2xvYmwgIiAjbmFtZSAiX3N0YXJ0XG4iKTsJXAorICBTVEFSVF9JTlNOUwkJ CQkJCVwKICAgc3RhdGljIHZvaWQJCQkJCQlcCiAgIG5hbWUgKHZvaWQpCQkJ CQkJXAogICB7CQkJCQkJCVwKZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUv Z2RiLmR3YXJmMi9kdzItZGlyLWZpbGUtbmFtZS5leHAgYi9nZGIvdGVzdHN1 aXRlL2dkYi5kd2FyZjIvZHcyLWRpci1maWxlLW5hbWUuZXhwCmluZGV4IDdm Mjk1ODEuLjZjOTI0NDEgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2Ri LmR3YXJmMi9kdzItZGlyLWZpbGUtbmFtZS5leHAKKysrIGIvZ2RiL3Rlc3Rz dWl0ZS9nZGIuZHdhcmYyL2R3Mi1kaXItZmlsZS1uYW1lLmV4cApAQCAtMTks NiArMTksMTMgQEAgaWYgeyFbZHdhcmYyX3N1cHBvcnRdfSB7CiAgICAgcmV0 dXJuIDAgIAogfQogCisjIEZpbmQgbGVuZ3RoIG9mIGFkZHJlc3NlcyBpbiBi eXRlcy4KK2lmIHtbaXNfNjRfdGFyZ2V0XX0geworICAgIHNldCBhZGRyX2xl biA4Cit9IGVsc2UgeworICAgIHNldCBhZGRyX2xlbiA0Cit9CisKIHN0YW5k YXJkX3Rlc3RmaWxlCiBzZXQgYXNtc3JjZmlsZSBbc3RhbmRhcmRfb3V0cHV0 X2ZpbGUgJHt0ZXN0ZmlsZX1hc20uU10KIHNldCBhc21vYmpmaWxlIFtzdGFu ZGFyZF9vdXRwdXRfZmlsZSAke3Rlc3RmaWxlfWFzbS5vXQpAQCAtMzYsNiAr NDMsNyBAQCBwdXRzICRmICIvKiBETyBOT1QgRURJVCEgR0VORVJBVEVEIEFV VE9NQVRJQ0FMTFkhICovIgogCiBwcm9jIG91dF9jdSB7IG5hbWUgY3VfZGly IGN1X25hbWUgbGluZV9kaXIgbGluZV9uYW1lIH0gewogICAgIGdsb2JhbCBm CisgICAgZ2xvYmFsIGFkZHJfbGVuCiAKICAgICBwdXRzIC1ub25ld2xpbmUg JGYgIlwKIC5MJHtuYW1lfV9iZWdpbjoKQEAgLTQzLDcgKzUxLDcgQEAgcHJv YyBvdXRfY3UgeyBuYW1lIGN1X2RpciBjdV9uYW1lIGxpbmVfZGlyIGxpbmVf bmFtZSB9IHsKIC5MJHtuYW1lfV9zdGFydDoKIAkuMmJ5dGUJMgkJCQkvKiBE V0FSRiBWZXJzaW9uICovCiAJLjRieXRlCS5MYWJicmV2MV9iZWdpbgkJCS8q IE9mZnNldCBpbnRvIGFiYnJldiBzZWN0aW9uICovCi0JLmJ5dGUJNAkJCQkv KiBQb2ludGVyIHNpemUgKi8KKwkuYnl0ZQkke2FkZHJfbGVufQkJCQkvKiBQ b2ludGVyIHNpemUgKi8KICIKICAgICBpZiB7ICRjdV9kaXIgIT0gIiIgfSB7 CiAJcHV0cyAkZiAiICAudWxlYjEyOCBBQkJSRVZfQ09NUF9ESVJfTkFNRSAv KiBBYmJyZXY6IERXX1RBR19jb21waWxlX3VuaXQgKi8iCkBAIC01NCw4ICs2 Miw4IEBAIHByb2Mgb3V0X2N1IHsgbmFtZSBjdV9kaXIgY3VfbmFtZSBsaW5l X2RpciBsaW5lX25hbWUgfSB7CiAJLmFzY2lpCVwiR05VIENcXDBcIgkJCS8q IERXX0FUX3Byb2R1Y2VyICovCiAJLmJ5dGUJMgkJCQkvKiBEV19BVF9sYW5n dWFnZSAoRFdfTEFOR19DKSAqLwogCS40Ynl0ZQkuTGxpbmVfJHtuYW1lfV9i ZWdpbgkJLyogRFdfQVRfc3RtdF9saXN0ICovCi0JLjRieXRlCSR7bmFtZX1f c3RhcnQJCQkvKiBEV19BVF9sb3dfcGMgKi8KLQkuNGJ5dGUJJHtuYW1lfV9l bmQJCQkvKiBEV19BVF9oaWdoX3BjICovCisJLiR7YWRkcl9sZW59Ynl0ZQkk e25hbWV9X3N0YXJ0CQkJLyogRFdfQVRfbG93X3BjICovCisJLiR7YWRkcl9s ZW59Ynl0ZQkke25hbWV9X2VuZAkJCS8qIERXX0FUX2hpZ2hfcGMgKi8KICIK ICAgICBpZiB7ICRjdV9kaXIgIT0gIiIgfSB7CiAJcHV0cyAkZiAiICAuYXNj aWkgJGN1X2RpciAvKiBEV19BVF9jb21wX2RpciAqLyIKQEAgLTY1LDggKzcz LDggQEAgcHJvYyBvdXRfY3UgeyBuYW1lIGN1X2RpciBjdV9uYW1lIGxpbmVf ZGlyIGxpbmVfbmFtZSB9IHsKIAogCS51bGViMTI4CTMJCQkvKiBBYmJyZXY6 IERXX1RBR19zdWJwcm9ncmFtICovCiAJLmFzY2l6CQlcIiR7bmFtZX1cIgkJ LyogRFdfQVRfbmFtZSAqLwotCS40Ynl0ZQkJJHtuYW1lfV9zdGFydAkJLyog RFdfQVRfbG93X3BjICovCi0JLjRieXRlCQkke25hbWV9X2VuZAkJLyogRFdf QVRfaGlnaF9wYyAqLworCS4ke2FkZHJfbGVufWJ5dGUJCSR7bmFtZX1fc3Rh cnQJCS8qIERXX0FUX2xvd19wYyAqLworCS4ke2FkZHJfbGVufWJ5dGUJCSR7 bmFtZX1fZW5kCQkvKiBEV19BVF9oaWdoX3BjICovCiAKIAkuYnl0ZQkJMAkJ CS8qIEVuZCBvZiBjaGlsZHJlbiBvZiBDVSAqLwogLkwke25hbWV9X2VuZDoK QEAgLTc1LDYgKzgzLDcgQEAgcHJvYyBvdXRfY3UgeyBuYW1lIGN1X2RpciBj dV9uYW1lIGxpbmVfZGlyIGxpbmVfbmFtZSB9IHsKIAogcHJvYyBvdXRfbGlu ZSB7IG5hbWUgY3VfZGlyIGN1X25hbWUgbGluZV9kaXIgbGluZV9uYW1lIH0g ewogICAgIGdsb2JhbCBmCisgICAgZ2xvYmFsIGFkZHJfbGVuCiAKICAgICBw dXRzIC1ub25ld2xpbmUgJGYgIlwKIC5MbGluZV8ke25hbWV9X2JlZ2luOgpA QCAtMTIwLDE2ICsxMjksMTYgQEAgcHJvYyBvdXRfbGluZSB7IG5hbWUgY3Vf ZGlyIGN1X25hbWUgbGluZV9kaXIgbGluZV9uYW1lIH0gewogCS5ieXRlCQkz CS8qIERXX0xOU19hZHZhbmNlX2xpbmUgKi8KIAkuc2xlYjEyOAk5OTgJLyog Li4uIHRvIDk5OSAqLwogCS5ieXRlCQkwCS8qIERXX0xORV9zZXRfYWRkcmVz cyAqLwotCS51bGViMTI4CTUKKwkudWxlYjEyOAkke2FkZHJfbGVufSsxCiAJ LmJ5dGUJCTIKLQkuNGJ5dGUJCSR7bmFtZX1fc3RhcnQKKwkuJHthZGRyX2xl bn1ieXRlCQkke25hbWV9X3N0YXJ0CiAJLmJ5dGUJCTEJLyogRFdfTE5TX2Nv cHkgKi8KIAkuYnl0ZQkJMwkvKiBEV19MTlNfYWR2YW5jZV9saW5lICovCiAJ LnNsZWIxMjgJMQkvKiAuLi4gdG8gMTAwMCAqLwogCS5ieXRlCQkwCS8qIERX X0xORV9zZXRfYWRkcmVzcyAqLwotCS51bGViMTI4CTUKKwkudWxlYjEyOAkk e2FkZHJfbGVufSsxCiAJLmJ5dGUJCTIKLQkuNGJ5dGUJCSR7bmFtZX1fZW5k CisJLiR7YWRkcl9sZW59Ynl0ZQkJJHtuYW1lfV9lbmQKIAkuYnl0ZQkJMQkv KiBEV19MTlNfY29weSAqLwogCS5ieXRlCQkwCS8qIERXX0xORV9lbmRfb2Zf c2VxdWVuY2UgKi8KIAkudWxlYjEyOAkxCg== --------------020206000105000209030406--