From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12625 invoked by alias); 10 Oct 2014 12:52:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12611 invoked by uid 89); 10 Oct 2014 12:52:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Oct 2014 12:52:55 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9ACqqGM004954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2014 08:52:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9ACqp6v016853; Fri, 10 Oct 2014 08:52:51 -0400 Message-ID: <5437D6A2.3070604@redhat.com> Date: Fri, 10 Oct 2014 12:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Fix non-stop regressions caused by "breakpoints always-inserted off" changes References: <1411657123-16228-1-git-send-email-palves@redhat.com> <1411657123-16228-4-git-send-email-palves@redhat.com> <87fveyu7db.fsf@codesourcery.com> In-Reply-To: <87fveyu7db.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00245.txt.bz2 On 10/08/2014 12:29 PM, Yao Qi wrote: > Pedro Alves writes: > >> - if (signal_print[ecs->event_thread->suspend.stop_signal]) >> - { >> - /* The signal table tells us to print about this signal. */ >> - printed = 1; >> - target_terminal_ours_for_output (); >> - observer_notify_signal_received (ecs->event_thread->suspend.stop_signal); >> - } >> /* Always stop on signals if we're either just gaining control >> of the program, or the user explicitly requested this thread >> to remain stopped. */ >> @@ -4214,10 +4207,17 @@ handle_signal_stop (struct execution_control_state *ecs) >> stop_waiting (ecs); >> return; >> } >> - /* If not going to stop, give terminal back >> - if we took it away. */ >> - else if (printed) > > The use of local variable 'printed' is removed by this patch. We can > remove 'printed' too, as the patch below does. It is obvious, and I'll > push it in. Thanks Yao. Thanks, Pedro Alves