From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14837 invoked by alias); 10 Oct 2014 09:38:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14826 invoked by uid 89); 10 Oct 2014 09:38:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 10 Oct 2014 09:38:16 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s9A9cDCd002292 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 10 Oct 2014 05:38:13 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s9A9cB8Q023676; Fri, 10 Oct 2014 05:38:12 -0400 Message-ID: <5437A902.6040701@redhat.com> Date: Fri, 10 Oct 2014 09:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Use command "monitor set debug 0" to check the connection References: <543404EF.4010306@redhat.com> <1412749679-27076-1-git-send-email-yao@codesourcery.com> <1412749679-27076-4-git-send-email-yao@codesourcery.com> <543547FC.30306@redhat.com> <87zjd6rlof.fsf@codesourcery.com> In-Reply-To: <87zjd6rlof.fsf@codesourcery.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00240.txt.bz2 On 10/09/2014 04:01 AM, Yao Qi wrote: > Pedro Alves writes: > >> That error is printed by trace_status_command, but only after calling >> target_get_trace_status, which seems to me should be sending a packet. >> >> remote_get_trace_status's exception swallowing should be >> letting TARGET_CLOSE_ERROR pass through. Is that not working? >> I'm a bit confused because it seems like if that didn't work, >> we should see a "qTStatus:..." error line in the logs. >> >> So what is preventing the packet from being sent? > > qTStatus is disabled after receiving the empty reply during connecting > to the remote target. Ah, thanks. I missed that we request the trace status on connection. So I think we should do "set remote trace-status-packet on" before the "tstatus". I know that the test originally didn't use "tstatus", but it's really the packet we should be testing for exercising that remote_get_trace_status's exception swallowing code, which was very much related to the original bug this test covered, see: https://sourceware.org/bugzilla/show_bug.cgi?id=15275 https://sourceware.org/ml/gdb-patches/2013-03/msg00691.html Thanks, Pedro Alves