From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124995 invoked by alias); 19 Oct 2016 12:20:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124981 invoked by uid 89); 19 Oct 2016 12:20:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=arrives, clients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Oct 2016 12:19:50 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A9EE3B717; Wed, 19 Oct 2016 12:19:49 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9JCJmHt021884; Wed, 19 Oct 2016 08:19:48 -0400 Subject: Re: Fix gdb 7.12 C++ compilation on Solaris To: Rainer Orth References: <5e1396ea-6599-6b9a-bc8b-f59defaf4c3a@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <54379347-b202-16c0-2d22-d50e101d4394@redhat.com> Date: Wed, 19 Oct 2016 12:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00563.txt.bz2 On 10/19/2016 12:53 PM, Rainer Orth wrote: > Besides, given that GCC 4.9 was the last version to support Solaris 9, > one might consider deprecating/removing anything before Solaris 10 in > gdb, too. That's be fine with me, but then again, I don't really use Solaris at all. :-) > > I'll see if I can find some spare cycles to clean procfs.c and friends > up: there are tons of opportunities with anything but Solaris gone as > clients of that file and a couple related ones. > >> FYI, AFAIK, no GDB maintainer cares for/tests on Solaris >> routinely nowadays. > > Neither do I: just whenever a new gdb or binutils release arrives, I > give them a try. I'm way behind even on Solaris/gcc maintenance, so I > fear there's not much I can do about gdb on that front. However, > there's a couple of Solaris patches for gdb 7.11 here: > > https://java.net/projects/solaris-userland/sources/gate/show/components/gdb/patches?rev=7127 > > Perhaps the authors can be motivated to contribute them upstream as they > obviously intended ;-) Indeed. (That page is not opening for me, server seems slow, can't see what the patches are about.) > >>> Still ok for mainline? >> >> Still OK. > > Thanks. I'll commit as soon as I've sorted some problem with hg-git > out: plain git is completely unusable for me. > Thanks. (FYI, we don't just put the ChangeLog entry in the commit log like gcc does. If you include the description of the problem as you had in the email in the git commit log, that'd be great.) > What about the 7.12 branch backport with the PR now filed? You just need to cherry pick the fix to the gdb-7.12-branch branch and push it. Just leave the atof call in place under !__cplusplus in the branch version, like you had in the original version, in case that was really necessary on some host. Thanks, Pedro Alves