From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3942 invoked by alias); 9 Oct 2014 16:29:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3932 invoked by uid 89); 9 Oct 2014 16:29:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a45.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a45.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Oct 2014 16:29:07 +0000 Received: from homiemail-a45.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a45.g.dreamhost.com (Postfix) with ESMTP id 8CC6B480C1; Thu, 9 Oct 2014 09:29:05 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a45.g.dreamhost.com (Postfix) with ESMTPSA id 2989D48057; Thu, 9 Oct 2014 09:29:05 -0700 (PDT) Message-ID: <5436B7D0.9060004@eagercon.com> Date: Thu, 09 Oct 2014 16:29:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ajit Kumar Agarwal , Pedro Alves , Joel Brobecker CC: "gdb-patches@sourceware.org" , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala Subject: Re: [Patch] Microblaze: Port of Linux gdbserver References: <25de23b98e054fd291ea232d10f2800c@BN1BFFO11FD018.protection.gbl> In-Reply-To: <25de23b98e054fd291ea232d10f2800c@BN1BFFO11FD018.protection.gbl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2014-10/txt/msg00209.txt.bz2 On 10/08/14 06:51, Ajit Kumar Agarwal wrote: > Please find the updated patch with feedback comments incorporated. Please don't top post and please trim email. Please respond to questions/comments inline. This makes it easier to tell whether all issues have been addressed. > Microblaze: Port of Linux gdbserver > > This patch is the port of Linux gdbserver. > Tested with gdb regression testsuite with this patch of > gdbserver. > > gdb/: > 2014-10-08 Ajit Agarwal > > * configure.tgt (build_gdbserver): New Definition. > > gdb/gdbserver/: > > * gdbserver/Makefile.in (microblaze-linux.c): New target. > * gdbserver/configure.srv (microblaze*-*-linux*): New target. > * gdbserver/linux-microblaze-low.c: New file. +#define microblaze_breakpoint_len 4 Use CAPS for macros. + (*the_target->read_memory) (where, (unsigned char *) &insn, 4); + + if (insn == microblaze_breakpoint) Why use the explicit length rather than the macro you just defined? Why not use sizeof (insn)? Pedro: > I'd much prefer if we had that patch in the tree before accepting further patches that tweak things around register names, etc. Could you send that (as an independent patch, in a new thread). Please address issues with previous patches before moving on to submit dependent patches. Pedro: > Did this kernel port make it upstream without PTRACE_GETREGSET? > If there's support for that, can you please switch to using it? Please answer all questions. Pedro: > PTRACE_GETREGS is supposed to an old way of doing things... And address all comments. Pedro: >diff --git a/gdb/regformats/microblaze-with-stack-protect.dat ... > Please send a preparatory, independent, patch that updates features/Makefile instead and generates this file, in a new thread, with self-contained description, following the > checklist: > https://sourceware.org/gdb/wiki/ContributionChecklist Preparatory means that the patch should be submitted before the current patch. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077